After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 636046 - The -r command line argument does not work if specified after the project name
The -r command line argument does not work if specified after the project name
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: General
Git
Other Linux
: Normal minor
: 0.14
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2010-11-29 09:34 UTC by Alex Băluț
Modified: 2010-12-08 14:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Using the OptionParser correctly (5.81 KB, patch)
2010-12-01 10:00 UTC, Alex Băluț 		none Details | Review

Description Alex Băluț 2010-11-29 09:34:50 UTC 
If I run "bin/pitivi project.xptv -r output.mkv" it does not seem to do anything, at least it doesn't render, the CPU is not used.

If there is a good reason for not making it work, at least an error should be printed.
Comment 1 Jean-François Fortin Tam 2010-11-30 14:22:36 UTC 
FWIW, it worked for me the other day with a syntax such as
bin/pitivi --no-ui --render output.mkv input.xptv

But I found bug #634715 along the way.
Comment 2 Alex Băluț 2010-12-01 08:06:06 UTC 
I found the problem, I'm working on a fix.
Comment 3 Alex Băluț 2010-12-01 10:00:32 UTC 
Created attachment 175611 [details] [review]
Using the OptionParser correctly

The basic change was to properly use OptionParser (change -r to store a str, not a boolean), then I had to change the run() method to properly use that value. I also did some cleanup, if you think it's too much please tell me and I'll split it into multiple patches.
Comment 4 Brandon Lewis 2010-12-01 14:56:42 UTC 
Review of attachment 175611 [details] [review]:

My main concern is the removal of the "no-gui" option. Is there a use case for headless pitivi other than rendering?
Comment 5 Brandon Lewis 2010-12-01 14:56:42 UTC 
Review of attachment 175611 [details] [review]:

My main concern is the removal of the "no-gui" option. Is there a use case for headless pitivi other than rendering?
Comment 6 Brandon Lewis 2010-12-01 16:04:43 UTC 
so the verdict seems to be
- we would appreciate the up the patch to be split up
- don't remove the --no-ui option
- we would prefer you not to change the copyright information in the file. Your
  name and email address will be included in the commit history.
Comment 7 Brandon Lewis 2010-12-01 16:52:22 UTC 
(In reply to comment #6)
> - we would prefer you not to change the copyright information in the file. Your
>   name and email address will be included in the commit history.

Just wanted to clarify this point a bit further. It's fine to assign copyright if the change is 'substantial' (and this could be considered 'substantial') but we would appreciate it if you would include a contact address.
Comment 8 Alex Băluț 2010-12-02 10:52:34 UTC 
The minimal change to fix this bug is to correctly use OptionParser, please have a look:
https://github.com/aleb/pitivi/commit/716186045593f3acffb9f1cf2fd9ddb1fc05687f
Comment 9 Brandon Lewis 2010-12-08 14:03:17 UTC 
commit 505017b7cfa1261abe04a608761097b5d01e2a53
Author: Alex Băluț <alexandru.balut@gmail.com>
Date:   Wed Dec 1 23:57:08 2010 +0100

    fix bug 636046 - Properly use OptionParser