After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 635503 - Allow clean builds from outside the source tree
Allow clean builds from outside the source tree
Status: RESOLVED OBSOLETE
Product: vala
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
: 683281 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-11-22 10:08 UTC by Mikkel Kamstrup Erlandsen
Modified: 2018-05-22 13:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch fixing the reported issue (4.21 KB, patch)
2010-11-22 10:08 UTC, Mikkel Kamstrup Erlandsen
none Details | Review
Patch - now git enaled (4.88 KB, patch)
2010-11-22 10:10 UTC, Mikkel Kamstrup Erlandsen
none Details | Review
Updated patch against latest master (5.17 KB, patch)
2016-10-04 18:34 UTC, Ole André Vadla Ravnås
needs-work Details | Review

Description Mikkel Kamstrup Erlandsen 2010-11-22 10:08:57 UTC
Created attachment 175014 [details] [review]
Patch fixing the reported issue

Vala fails to if you do a clean build in a directory that is not the source root (ie. "clean" as in "not from tarball, but from a clean source tree"). This is fx. the case if you do a jhbuild with buildroot!=None like we do in Unity.

The attached patch fixes this.

DISCLAIMER: I've not checked 'make distcheck' after this, but I'm quite sure it shouldn't break.
Comment 1 Mikkel Kamstrup Erlandsen 2010-11-22 10:10:12 UTC
Created attachment 175015 [details] [review]
Patch - now git enaled

And why not attach the patch I made with git format-patch instead? ;-)
Comment 2 Mikkel Kamstrup Erlandsen 2010-11-22 10:41:10 UTC
(for the record - I've now tested that distcheck indeed still passes)
Comment 3 Jürg Billeter 2012-09-03 20:06:00 UTC
*** Bug 683281 has been marked as a duplicate of this bug. ***
Comment 4 Ole André Vadla Ravnås 2016-10-04 18:34:36 UTC
Created attachment 336945 [details] [review]
Updated patch against latest master
Comment 5 Rico Tzschichholz 2016-10-05 14:21:52 UTC
@ole: This won't work that easily since we need to ship the generated c-code in the tarball.
Comment 6 Ole André Vadla Ravnås 2016-10-05 14:59:58 UTC
@Rico: Ooh right, I totally didn't think of that. Sorry.
Comment 7 GNOME Infrastructure Team 2018-05-22 13:48:25 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/vala/issues/146.