After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632642 - Port to Gtk3
Port to Gtk3
Status: RESOLVED FIXED
Product: Evolution Webcal
Classification: Deprecated
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Rodney Dawes
Rodney Dawes
Depends on:
Blocks:
 
 
Reported: 2010-10-20 08:32 UTC by Matthias Clasen
Modified: 2011-06-20 09:16 UTC
See Also:
GNOME target: 3.0
GNOME version: ---


Attachments
patch (1.15 KB, patch)
2010-10-20 08:32 UTC, Matthias Clasen
accepted-commit_now Details | Review
evo-webcal patch (3.58 KB, patch)
2011-02-14 09:23 UTC, Milan Crha
committed Details | Review

Description Matthias Clasen 2010-10-20 08:32:56 UTC
Created attachment 172798 [details] [review]
patch

it is being replaced  by GtkComboBoxText in GTK3
Comment 1 André Klapper 2011-01-10 11:31:18 UTC
Comment on attachment 172798 [details] [review]
patch

Matthias: Please just commit, it's unmaintained anyway.
Comment 2 Milan Crha 2011-02-14 09:23:29 UTC
Created attachment 180808 [details] [review]
evo-webcal patch

for evolution-webcal;

It was still requiring gtk2, where this issue wasn't visible. I made it depend on gtk3 and "ported" it there as well, by extending Mathias' patch.
Comment 3 Milan Crha 2011-02-14 09:25:54 UTC
Created commit 506b6a0 in evo-webcal master (anything after 2.32.1 I guess)
Comment 4 Sebastien Bacher 2011-06-17 15:52:44 UTC
did you meant to commit the evolution-webcal-main.c changes in http://git.gnome.org/browse/evolution-webcal/commit/?id=506b6a0014074cc654d5e8990fc33b0b7cbcc5f4 as well? they don't seem to have to do with the gtk3 switch
Comment 5 Milan Crha 2011-06-20 06:24:49 UTC
(In reply to comment #4)
> did you meant to commit the evolution-webcal-main.c changes in
> http://git.gnome.org/browse/evolution-webcal/commit/?id=506b6a0
> as well? they don't seem to have to do with the gtk3 switch

I made the change together with this commit, yes. And yes, it's not related to gtk3 at all, that's right. Does that part have any regression?
Comment 6 Sebastien Bacher 2011-06-20 09:16:16 UTC
No issue that I know, I was just looking at building the source with gtk3 on Ubuntu and wondered if those changes were local diff commited by mistake or wanted since they are not described on the bug nor in the commit