After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632429 - Port to GSettings
Port to GSettings
Status: RESOLVED FIXED
Product: gnome-search-tool
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-search-tool-maint
gnome-search-tool-maint
Depends on:
Blocks: 622558
 
 
Reported: 2010-10-18 05:18 UTC by Dennis Cranston
Modified: 2012-08-06 08:27 UTC
See Also:
GNOME target: 3.6
GNOME version: 3.1/3.2


Attachments
Work-in-progress: Port the gsearchtool-entry code to GSettings. (6.72 KB, patch)
2010-10-18 05:18 UTC, Dennis Cranston
none Details | Review
port gnome-search-tool to GSettings (71.65 KB, patch)
2012-07-27 10:59 UTC, Marek Kašík
none Details | Review
port gnome-search-tool to GSettings (76.24 KB, patch)
2012-07-30 14:21 UTC, Marek Kašík
committed Details | Review

Description Dennis Cranston 2010-10-18 05:18:51 UTC
Created attachment 172580 [details] [review]
Work-in-progress:  Port the gsearchtool-entry code to GSettings.

The search-tool should be migrated from gconf to GSettings.
Comment 1 Emmanuele Bassi (:ebassi) 2011-02-02 14:03:33 UTC
Review of attachment 172580 [details] [review]:

the patch is missing the GSettings schema file referenced in the Makefile.am
Comment 2 Emmanuele Bassi (:ebassi) 2011-02-17 13:23:52 UTC
setting for 3.2 to remove from the blocker list. though it would be nice to have, since gsearchtool is now the only component of gnome-utils that depends on gconf (except the gdict-applet, but that is disabled by default).
Comment 3 Matthias Clasen 2011-09-09 13:00:26 UTC
I don't think this is on anybody's radar  for 3.2
Comment 4 André Klapper 2012-03-06 15:53:02 UTC
Dennis: Do you have time to rework the patch?
Comment 5 Marek Kašík 2012-07-27 10:59:55 UTC
Created attachment 219731 [details] [review]
port gnome-search-tool to GSettings

Hi this patch migrates gnome-search-tool to GSettings.
It adds new key "search-history" which is a dictionary where values are lists of strings and removes getting of value of nautilus key "date_format" because it was removed from nautilus.
This commit also contains conversion file gnome-search-tool.convert for data conversion.
Comment 6 Dennis Cranston 2012-07-28 16:44:11 UTC
Thanks for the patch.  Overall, I think it looks good.  

A couple issues or concerns:

1.  When I applied the patch and ran gnome-search-tool, the following message is printed to the terminal:

GLib-GIO-Message: Using the 'memory' GSettings backend.  Your settings will not be saved or shared with other applications.

So, I was am able to verify configuration settings are properly saved between runs.  Maybe this has something to do with how I setup my development environment?

2.  The help document needs to be updated too.  In the "Settings" section, we refer to gconf keys and values and give commands using gconf-editor.  These need to be updated to the appropriate GSettings language and commands.
Comment 7 Dennis Cranston 2012-07-30 05:17:52 UTC
I confirmed issue #1 from above was with my setup.  Only issue #2 needs to be resolved before the patch should be committed.
Comment 8 Marek Kašík 2012-07-30 14:21:35 UTC
Created attachment 219892 [details] [review]
port gnome-search-tool to GSettings

(In reply to comment #6)
> Thanks for the patch.  Overall, I think it looks good.  

Thanks.

> A couple issues or concerns:
> 
> 2.  The help document needs to be updated too.  In the "Settings" section, we
> refer to gconf keys and values and give commands using gconf-editor.  These
> need to be updated to the appropriate GSettings language and commands.

I've updated the document. I used dconf-editor instead of gconf-editor. It should be ok because dconf is the backend which is currently used by gsettings.
Or would you prefer to add there command-line commands for those (e.g. "gsettings set org.gnome.gnome-search-tool disable-quick-search true")?
Comment 9 Dennis Cranston 2012-08-03 04:01:26 UTC
Thanks Marek.  Please push to master.
Comment 10 Marek Kašík 2012-08-06 08:26:59 UTC
Comment on attachment 219892 [details] [review]
port gnome-search-tool to GSettings

(In reply to comment #9)
> Thanks Marek.  Please push to master.

Thanks. Committed.

Marek