GNOME Bugzilla – Bug 632429
Port to GSettings
Last modified: 2012-08-06 08:27:14 UTC
Created attachment 172580 [details] [review] Work-in-progress: Port the gsearchtool-entry code to GSettings. The search-tool should be migrated from gconf to GSettings.
Review of attachment 172580 [details] [review]: the patch is missing the GSettings schema file referenced in the Makefile.am
setting for 3.2 to remove from the blocker list. though it would be nice to have, since gsearchtool is now the only component of gnome-utils that depends on gconf (except the gdict-applet, but that is disabled by default).
I don't think this is on anybody's radar for 3.2
Dennis: Do you have time to rework the patch?
Created attachment 219731 [details] [review] port gnome-search-tool to GSettings Hi this patch migrates gnome-search-tool to GSettings. It adds new key "search-history" which is a dictionary where values are lists of strings and removes getting of value of nautilus key "date_format" because it was removed from nautilus. This commit also contains conversion file gnome-search-tool.convert for data conversion.
Thanks for the patch. Overall, I think it looks good. A couple issues or concerns: 1. When I applied the patch and ran gnome-search-tool, the following message is printed to the terminal: GLib-GIO-Message: Using the 'memory' GSettings backend. Your settings will not be saved or shared with other applications. So, I was am able to verify configuration settings are properly saved between runs. Maybe this has something to do with how I setup my development environment? 2. The help document needs to be updated too. In the "Settings" section, we refer to gconf keys and values and give commands using gconf-editor. These need to be updated to the appropriate GSettings language and commands.
I confirmed issue #1 from above was with my setup. Only issue #2 needs to be resolved before the patch should be committed.
Created attachment 219892 [details] [review] port gnome-search-tool to GSettings (In reply to comment #6) > Thanks for the patch. Overall, I think it looks good. Thanks. > A couple issues or concerns: > > 2. The help document needs to be updated too. In the "Settings" section, we > refer to gconf keys and values and give commands using gconf-editor. These > need to be updated to the appropriate GSettings language and commands. I've updated the document. I used dconf-editor instead of gconf-editor. It should be ok because dconf is the backend which is currently used by gsettings. Or would you prefer to add there command-line commands for those (e.g. "gsettings set org.gnome.gnome-search-tool disable-quick-search true")?
Thanks Marek. Please push to master.
Comment on attachment 219892 [details] [review] port gnome-search-tool to GSettings (In reply to comment #9) > Thanks Marek. Please push to master. Thanks. Committed. Marek