After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630711 - Screensaver not inhibited when playing video
Screensaver not inhibited when playing video
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Plugins
2.31.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-09-27 10:02 UTC by Chris Coulson
Modified: 2011-02-21 05:58 UTC
See Also:
GNOME target: 3.0
GNOME version: ---


Attachments
0001-Fix-630711-Screensaver-not-inhibited-when-playing-vi.patch (5.97 KB, patch)
2010-09-27 10:13 UTC, Chris Coulson
none Details | Review

Description Chris Coulson 2010-09-27 10:02:09 UTC
If I open a video in Totem (by double-clicking it in Nautilus), the screensaver is not inhibited. However, if I pause and resume the video, the screensaver becomes inhibited.

This has regressed because of the port to GDBus. Because g_dbus_proxy_new_for_bus is asynchronous, then any calls to inhibit the screensaver before running the main loop (which seems to be what is happening) will fall back to X11 inhibit, because the dbus proxy will not be set up yet.

Unfortunately, X11 inhibit doesn't do anything on Ubuntu because of a patch we inherited from Debian to unconditionally disable the xtest code.

I'll attach a patch for this shortly
Comment 1 Chris Coulson 2010-09-27 10:13:50 UTC
Created attachment 171188 [details] [review]
0001-Fix-630711-Screensaver-not-inhibited-when-playing-vi.patch

This patch fixes it by making sure that attempts to disable the screensaver are postponed until screensaver_dbus_proxy_new_cb has been dispatched
Comment 2 Julian Sikorski 2010-11-10 14:50:45 UTC
Totem 2.32.0 does not build with this patch applied. The build log is attached to bug 618375.
Comment 3 Julian Sikorski 2010-11-10 14:51:31 UTC
Oops, that would be bug 618385.
Comment 4 Julian Sikorski 2010-11-24 20:51:02 UTC
Hmm, I am actually seeing this issue on Fedora 14 with a fresh user account. On an old account, whether the file is played from nautilus or from file → open makes no difference.
Comment 5 hunteke 2010-12-24 15:59:40 UTC
I have noticed this on Ubuntu for at least Lucid, and still in Maverick as well.  I did some initial researching for myself via this comment on Launchpad:

https://bugs.launchpad.net/ubuntu/+source/totem/+bug/570949/comments/3

I'm gathering y'all are more on the money, but I offer this as an end-users attempt to help.

I'm also curious if xscreensaver and gnome-screensaver are both supported by totem?  I thought things were working with gnome-screensaver when I initially installed Maverick, but then I swapped out gnome-screensaver for xscreensaver and now I have to manually inhibit it while I watch movies.
Comment 6 hunteke 2010-12-24 16:09:43 UTC
I'm also not clear on if I should report this error against Bug 630711 (this bug), or against Bug 567908 ?
Comment 7 Bastien Nocera 2011-02-21 05:58:28 UTC
Much much simpler version in master and gnome-2-32.

commit 157466dfc55b0315fda5f7731eedb9aa27540c83
Author: Bastien Nocera <hadess@hadess.net>
Date:   Mon Feb 21 05:49:53 2011 +0000

    scrsaver: Disable even when fullscreen comes quick
    
    As the screensaver might be disabled before we get access
    to the D-Bus proxy, try again after we have the proxy.
    
    Spotted by Chris Coulson.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=630711