After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630681 - drop GtkObject use
drop GtkObject use
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks: 630874
 
 
Reported: 2010-09-27 03:15 UTC by Matthias Clasen
Modified: 2014-06-08 14:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (3.85 KB, patch)
2010-09-27 03:15 UTC, Matthias Clasen 		needs-work Details | Review

Description Matthias Clasen 2010-09-27 03:15:54 UTC 
Created attachment 171163 [details] [review]
patch

GtkObject is gone in GTK3. See
http://live.gnome.org/GnomeGoals/GtkObjectRemoval
Comment 1 Thomas Thurman 2011-01-15 23:04:26 UTC 
Review of attachment 171163 [details] [review]:

(In reply to comment #0)
> Created an attachment (id=171163) [details] [review]
> patch
> 
> GtkObject is gone in GTK3. See
> http://live.gnome.org/GnomeGoals/GtkObjectRemoval

Sorry for the delay in replying.  I'll try to do better in future.

This doesn't compile for me.  Is it dependent on something else?  Specifically, GtkWidgetClass (unlike GtkObjectClass) has no member "destroy", yet code in src/ui/frames.c attempts to assign to it.

I have created a branch in git with this patch checked in:
http://git.gnome.org/browse/metacity/log/?h=bug630681
Comment 2 Matthias Clasen 2011-02-26 00:00:23 UTC 
Yeah, this patch misses the configure part where you need to build against gtk3...
Comment 3 André Klapper 2011-03-03 20:51:53 UTC 
[Removing GNOME3.0 target as decided in release-team meeting on March 03, 2011. "nice-to-have" categorisation for GNOME3.0]
Comment 4 André Klapper 2012-02-06 15:48:22 UTC 
Still existing in git master in 
./src/ui/metaaccellabel.c
./src/ui/frames.c

I vote for just committing, like for bug 572332.
Comment 5 Matthias Clasen 2012-02-06 18:06:00 UTC 
Florian, can you put this in your queue ?
Comment 6 Florian Müllner 2012-02-06 18:26:43 UTC 
Do we actually still want this? As far as I can see, the patch requires a port from GTK+-2 to GTK+-3, which involves a lot more than some configure glue (mostly the GtkWidget::expose-event => GtkWidget::draw change). It's not particularly difficult to do given that the work has been done for Mutter already, but considering the recent mesa improvements, I do wonder if it's reasonable to spend much time on Metacity ...
Comment 7 Matthias Clasen 2012-02-06 22:22:52 UTC 
you may be right. feel free to close it out, then