GNOME Bugzilla – Bug 629811
Labels of the keyframe control points at wrong positions or don't show up at all
Last modified: 2010-09-17 14:10:01 UTC
For a video clip in the first track (topmost video layer), so that it starts at 0, you will get a label that shows the percentage of the keyframe control point you're hovering over and dragging. But this doesn't work correctly anywhere else except in this first video layer. Everywhere else these labels don't show up at all or about one layer lower than where they should, and are only updated after releasing the mouse button (not while dragging). Also the labels change their relative position to their control point if you move the clip or change the in-point, even for the topmost video layer.
Fix: diff --git a/pitivi/ui/curve.py b/pitivi/ui/curve.py index 581be8c..0ec9d06 100644 --- a/pitivi/ui/curve.py +++ b/pitivi/ui/curve.py @@ -217,9 +217,9 @@ class Curve(goocanvas.ItemSimple, goocanvas.Item, View, Zoom self.keyframes[kf] = pos def do_simple_paint(self, cr, bounds): - cr.save() cr.identity_matrix() if self.interpolator: + cr.save() # set clipping region to the visible portion of the clip vis_bounds = intersect( This works, but I don't know if it's OK to leave cr as set by cr.identity_matrix() or if do_simple_paint() should restore cr to the state it had when entering the function. In the latter case we'd need an additional save/restore pair around the whole function. But before cr.reset_clip() was eliminated in a9795568f5a0adca5a4277bf51868a5a30ff99dd it was like it's now with this patch (provided I understand cr.reset_clip() correctly and it doesn't change the matrix of cr.)
Created attachment 170431 [details] [review] Fix wrong positions of keyframe value labels
commit 5289ebd332277160bdb44a24debe58c7ada3d5fd Author: Volker Sobek <reklov@live.com> Date: Thu Sep 16 16:33:37 2010 +0200 Fix wrong positions of keyframe value labels Fixes #629811