After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629438 - [PATCH] LyricWiki plugin revivification
[PATCH] LyricWiki plugin revivification
Status: RESOLVED WONTFIX
Product: rhythmbox
Classification: Other
Component: Plugins (other)
0.13.x
Other All
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-09-12 16:25 UTC by Oleg
Modified: 2010-09-15 17:47 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
LyricWiki plugin patch (5.36 KB, patch)
2010-09-12 16:25 UTC, Oleg
none Details | Review

Description Oleg 2010-09-12 16:25:36 UTC
Created attachment 170087 [details] [review]
LyricWiki plugin patch

I fixed the LyricWiki plugin. LyricWiki is a good lyrics resource. Please include it to the mainstream.
Comment 1 Jonathan Matthew 2010-09-12 21:12:41 UTC
Unfortunately we can't do that.  Abusing the site like this is only going to make it worse for everyone.
Comment 2 Oleg 2010-09-13 02:43:17 UTC
What's wrong with this site? Lyrics fetched via API. It is legal.
So, other famous opensource player use this lyrics resource and there is no problems.
Comment 3 Jonathan Matthew 2010-09-13 03:01:41 UTC
The lyricwiki FAQ (http://lyrics.wikia.com/Help:FAQ) states that they can't provide an API that returns full lyrics.  If we abuse other features of their site to do this, they'll either blacklist by user agent or break the site in some other way.  It may be legal, but it's not ethical.
Comment 4 Oleg 2010-09-13 03:16:28 UTC
Ok. I think you need to remove LyricWikiParser.py from rhythmbox source tree to avoid misleading
Comment 5 Oleg 2010-09-15 17:47:41 UTC
If anyone interested I published plugin on gnomfiles.org: http://gnomefiles.org/content/show.php?action=content&content=132647