After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 629342 - Build broken with introspection using gobject-introspection from master
Build broken with introspection using gobject-introspection from master
Status: RESOLVED FIXED
Product: totem-pl-parser
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: totem-pl-parser-maint
totem-pl-parser-maint
: 629520 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-09-11 08:36 UTC by Kjartan Maraas
Modified: 2010-09-16 05:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Update g-ir-scanner options (1.59 KB, patch)
2010-09-13 23:07 UTC, Philip Withnall
none Details | Review

Description Kjartan Maraas 2010-09-11 08:36:07 UTC
make[4]: Entering directory `/home/kmaraas/src/gnome/totem-pl-parser/plparse'
  GEN    stamp-totem-pl-parser-builtins.h
  GEN    totem-pl-parser-builtins.c
  CC     libtotem_plparser_la-totem-pl-parser-builtins.lo
  CCLD   libtotem-plparser.la
  GISCAN TotemPlParser-1.0.gir
g-ir-scanner: warning: Option --strip-prefix has been deprecated;
see --identifier-prefix and --symbol-prefix.
Traceback (most recent call last):
  • File "/opt/gnome2/bin/g-ir-scanner", line 45 in <module>
    sys.exit(scanner_main(sys.argv))
  • File "/opt/gnome2/lib/gobject-introspection/giscanner/scannermain.py", line 343 in scanner_main
    gdump_parser.parse()
  • File "/opt/gnome2/lib/gobject-introspection/giscanner/gdumpparser.py", line 108 in parse
    self._introspect_type(child)
  • File "/opt/gnome2/lib/gobject-introspection/giscanner/gdumpparser.py", line 238 in _introspect_type
    self._introspect_object(xmlnode)
  • File "/opt/gnome2/lib/gobject-introspection/giscanner/gdumpparser.py", line 293 in _introspect_object
    (get_type, c_symbol_prefix) = self._split_type_and_symbol_prefix(xmlnode)
  • File "/opt/gnome2/lib/gobject-introspection/giscanner/gdumpparser.py", line 282 in _split_type_and_symbol_prefix
    assert name.endswith('_get_type') AssertionError make[4]: *** [TotemPlParser-1.0.gir] Error 1 make[4]: Leaving directory `/home/kmaraas/src/gnome/totem-pl-parser/plparse' make[3]: *** [all-recursive] Error 1 make[3]: Leaving directory `/home/kmaraas/src/gnome/totem-pl-parser/plparse' make[2]: *** [all] Error 2 make[2]: Leaving directory `/home/kmaraas/src/gnome/totem-pl-parser/plparse' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/kmaraas/src/gnome/totem-pl-parser' make: *** [all] Error 2 [kmaraas@e4300 totem-pl-parser]\$

Comment 1 Vincent Untz 2010-09-11 12:28:37 UTC
This is possibly a duplicate of bug 629355.
Comment 2 Philip Withnall 2010-09-13 14:18:22 UTC
*** Bug 629520 has been marked as a duplicate of this bug. ***
Comment 3 Philip Withnall 2010-09-13 23:07:08 UTC
Created attachment 170199 [details] [review]
Update g-ir-scanner options

This can only be applied after we branch for 2.32, and requires a little bit of thought since it breaks the introspection API (which is unavoidable). We want to make sure we get it right.
Comment 4 Vincent Untz 2010-09-14 06:12:50 UTC
(In reply to comment #3)
> Created an attachment (id=170199) [details] [review]
> Update g-ir-scanner options
> 
> This can only be applied after we branch for 2.32,

Except that we're considering releasing 2.32 with gobject-introspection 0.9.5, which will trigger this issue :/
Comment 5 Götz Waschk 2010-09-14 07:43:48 UTC
The patch makes it build with g-i 0.9.5 just fine.
Comment 6 Philip Withnall 2010-09-14 07:52:49 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > Created an attachment (id=170199) [details] [review] [details] [review]
> > Update g-ir-scanner options
> > 
> > This can only be applied after we branch for 2.32,
> 
> Except that we're considering releasing 2.32 with gobject-introspection 0.9.5,
> which will trigger this issue :/

We haven't yet made a 2.31.x release for totem-pl-parser, so I suppose we could branch for 2.30, apply this patch and release 2.31.92. The only problem is that means we break the introspection API with a minor release. Though if GNOME 2.32 is shipping with g-i 0.9.5, we're not going to be the only ones.
Comment 7 Colin Walters 2010-09-14 13:52:14 UTC
Actually --strip-prefix is back; so this patch just probably needs to fix the --strip-prefix being used.
Comment 8 Philip Withnall 2010-09-15 08:47:00 UTC
Isn't --strip-prefix still deprecated though? Bastien, do you want me to drop the g-i dependency bump from the patch and go with --strip-prefix, though it'll spout warnings if we use it?
Comment 9 Colin Walters 2010-09-15 13:36:57 UTC
(In reply to comment #8)
> Isn't --strip-prefix still deprecated though? 

Yes, but:

> Bastien, do you want me to drop
> the g-i dependency bump from the patch and go with --strip-prefix, though it'll
> spout warnings if we use it?

It's just one warning line.

(I could even remove the warning temporarily for the next release if we really care)
Comment 10 Bastien Nocera 2010-09-15 13:57:50 UTC
If it's possible to make it work with a simple warning for the new g-i and working with the old g-i, and without the need for branching, I'd rather have that indeed.
Comment 11 Philip Withnall 2010-09-15 20:49:12 UTC
I decided to branch anyway, as the GIR changes break the GIR API. Released in 2.31.92, using --strip-prefix and without bumping the g-i dependency.

commit 7cd2a4e2da69aabbb01eb40190fcae88dc427ef2
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Tue Sep 14 00:01:13 2010 +0100

    Update g-ir-scanner options
    
    This changes the prefix used in totem-pl-parser's GIR file to “TotemPl”,
    breaking introspection API. It makes things neater, however, and does fix the
    introspection build. This works with old versions of gobject-introspection,
    but ideally we'd depend on 0.9.5 with this change. Closes: bgo#629342

 plparse/Makefile.am |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Comment 12 Hussam Al-Tayeb 2010-09-16 04:41:03 UTC
I get 
ERROR: Option --strip-prefix has been replaced;
see --identifier-prefix and --symbol-prefix.
with g-i 0.9.5 and totem-pl-parser 2.31.92

but changing --strip-prefix to --identifier-prefix fixes it.
Comment 13 Götz Waschk 2010-09-16 05:45:25 UTC
(In reply to comment #12)
You need g-i from git which has readded the --strip-prefix option.