GNOME Bugzilla – Bug 629342
Build broken with introspection using gobject-introspection from master
Last modified: 2010-09-16 05:45:25 UTC
make[4]: Entering directory `/home/kmaraas/src/gnome/totem-pl-parser/plparse' GEN stamp-totem-pl-parser-builtins.h GEN totem-pl-parser-builtins.c CC libtotem_plparser_la-totem-pl-parser-builtins.lo CCLD libtotem-plparser.la GISCAN TotemPlParser-1.0.gir g-ir-scanner: warning: Option --strip-prefix has been deprecated; see --identifier-prefix and --symbol-prefix. Traceback (most recent call last):
+ Trace 223647
sys.exit(scanner_main(sys.argv))
gdump_parser.parse()
self._introspect_type(child)
self._introspect_object(xmlnode)
(get_type, c_symbol_prefix) = self._split_type_and_symbol_prefix(xmlnode)
assert name.endswith('_get_type') AssertionError make[4]: *** [TotemPlParser-1.0.gir] Error 1 make[4]: Leaving directory `/home/kmaraas/src/gnome/totem-pl-parser/plparse' make[3]: *** [all-recursive] Error 1 make[3]: Leaving directory `/home/kmaraas/src/gnome/totem-pl-parser/plparse' make[2]: *** [all] Error 2 make[2]: Leaving directory `/home/kmaraas/src/gnome/totem-pl-parser/plparse' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/kmaraas/src/gnome/totem-pl-parser' make: *** [all] Error 2 [kmaraas@e4300 totem-pl-parser]\$
This is possibly a duplicate of bug 629355.
*** Bug 629520 has been marked as a duplicate of this bug. ***
Created attachment 170199 [details] [review] Update g-ir-scanner options This can only be applied after we branch for 2.32, and requires a little bit of thought since it breaks the introspection API (which is unavoidable). We want to make sure we get it right.
(In reply to comment #3) > Created an attachment (id=170199) [details] [review] > Update g-ir-scanner options > > This can only be applied after we branch for 2.32, Except that we're considering releasing 2.32 with gobject-introspection 0.9.5, which will trigger this issue :/
The patch makes it build with g-i 0.9.5 just fine.
(In reply to comment #4) > (In reply to comment #3) > > Created an attachment (id=170199) [details] [review] [details] [review] > > Update g-ir-scanner options > > > > This can only be applied after we branch for 2.32, > > Except that we're considering releasing 2.32 with gobject-introspection 0.9.5, > which will trigger this issue :/ We haven't yet made a 2.31.x release for totem-pl-parser, so I suppose we could branch for 2.30, apply this patch and release 2.31.92. The only problem is that means we break the introspection API with a minor release. Though if GNOME 2.32 is shipping with g-i 0.9.5, we're not going to be the only ones.
Actually --strip-prefix is back; so this patch just probably needs to fix the --strip-prefix being used.
Isn't --strip-prefix still deprecated though? Bastien, do you want me to drop the g-i dependency bump from the patch and go with --strip-prefix, though it'll spout warnings if we use it?
(In reply to comment #8) > Isn't --strip-prefix still deprecated though? Yes, but: > Bastien, do you want me to drop > the g-i dependency bump from the patch and go with --strip-prefix, though it'll > spout warnings if we use it? It's just one warning line. (I could even remove the warning temporarily for the next release if we really care)
If it's possible to make it work with a simple warning for the new g-i and working with the old g-i, and without the need for branching, I'd rather have that indeed.
I decided to branch anyway, as the GIR changes break the GIR API. Released in 2.31.92, using --strip-prefix and without bumping the g-i dependency. commit 7cd2a4e2da69aabbb01eb40190fcae88dc427ef2 Author: Philip Withnall <philip@tecnocode.co.uk> Date: Tue Sep 14 00:01:13 2010 +0100 Update g-ir-scanner options This changes the prefix used in totem-pl-parser's GIR file to “TotemPl”, breaking introspection API. It makes things neater, however, and does fix the introspection build. This works with old versions of gobject-introspection, but ideally we'd depend on 0.9.5 with this change. Closes: bgo#629342 plparse/Makefile.am | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
I get ERROR: Option --strip-prefix has been replaced; see --identifier-prefix and --symbol-prefix. with g-i 0.9.5 and totem-pl-parser 2.31.92 but changing --strip-prefix to --identifier-prefix fixes it.
(In reply to comment #12) You need g-i from git which has readded the --strip-prefix option.