After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 628457 - pam header test defective
pam header test defective
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
: 628990 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-08-31 23:41 UTC by Matthias Clasen
Modified: 2010-09-08 02:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (677 bytes, patch)
2010-08-31 23:41 UTC, Matthias Clasen
none Details | Review

Description Matthias Clasen 2010-08-31 23:41:17 UTC
Fedora has pam headers in /usr/include/security. The AC_CHECK_HEADERS check fails to find them, since it loops over all headers, and first sets have_pam to true (because it finds security/pam-modules.h), and then sets it to false (because it doesn't find pam/pam-modules.h). The if-found clause needs to break out of the loop after the first found headers.
Comment 1 Matthias Clasen 2010-08-31 23:41:51 UTC
Created attachment 169203 [details] [review]
patch
Comment 2 Stef Walter 2010-09-01 01:15:10 UTC
Awesome. Thanks. Applied patch to master.


commit 19f50bcdd0e762625c03b66a5533eecda0ada391
Author: Matthias Clasen <mclasen@redhat.com>
Date:   Wed Sep 1 01:06:20 2010 +0000

    [pam] Fix PAM header test.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=628457
Comment 3 Stef Walter 2010-09-08 02:17:07 UTC
*** Bug 628990 has been marked as a duplicate of this bug. ***