After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 625444 - Don't use deprecated GDK drawing APIs
Don't use deprecated GDK drawing APIs
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-games-general-maint
GNOME Games maintainers
Depends on: 632856 633464
Blocks: 626688
 
 
Reported: 2010-07-27 22:49 UTC by Thomas Andersen
Modified: 2014-02-28 14:53 UTC
See Also:
GNOME target: 3.0
GNOME version: ---


Attachments
[glines] Port to cairo (8.26 KB, patch)
2010-07-27 22:53 UTC, Thomas Andersen
committed Details | Review
[gnotravex] Complete the port to cairo (4.46 KB, patch)
2010-08-11 16:47 UTC, Thomas Andersen
committed Details | Review

Description Thomas Andersen 2010-07-27 22:49:34 UTC
A lot of the old drawing API is going away so it is time to port the games to using cairo instead.
http://mail.gnome.org/archives/gtk-devel-list/2010-July/msg00036.html
Comment 1 Thomas Andersen 2010-07-27 22:53:00 UTC
Created attachment 166672 [details] [review]
[glines] Port to cairo
Comment 2 Christian Persch 2010-07-27 23:07:28 UTC
For aisleriot, I want to preserve the old code, like this (board-noclutter.c):
#ifdef CAIRO_RENDERING { new code } #else { old code } #endif, and define CAIRO_RENDERING on gtk 2.90 only for now.
Comment 3 Thomas Andersen 2010-08-09 17:55:51 UTC
Comment on attachment 166672 [details] [review]
[glines] Port to cairo

Committed with small changes suggested by Benjamin Otte.
Comment 4 Thomas Andersen 2010-08-11 16:47:03 UTC
Created attachment 167637 [details] [review]
[gnotravex] Complete the port to cairo
Comment 5 Christian Persch 2010-08-11 17:06:46 UTC
BTW, I've ported aisleriot already (just not pushed to git yet, since it has a tiny glitch).
Comment 6 Christian Persch 2010-08-18 13:36:32 UTC
Aisleriot is done on master and 2-32 branch.
Comment 7 Thomas Andersen 2010-10-21 09:15:08 UTC
Just a quick status update on this:

Working with gtk3:
- aisleriot
- glines (with http://git.gnome.org/browse/gnome-games/commit/?id=7e4a13a0e4d85983c999f9877a18fbfec206bebb)

the rest is todo. I plan to look at gnotravex and gnomine next.
Comment 8 Thomas Andersen 2010-11-03 21:29:01 UTC
chpe has taken care of gnect. With todays commits the working list is up to:
aisleriot, gnect, gnotski, glines, and gtali

I talked to Tim and he said he would look at reviewing patches for lightsoff and swell-foop. And other work needed to get them working again.

Jason is taking care of gnometris.

Robert has begun the work on vala ports of chess and sudoku.

Missing pieces are:
gnibbles, gnobots, gnomine, gnotravex, iagno, and mahjongg
Comment 9 Robert Ancell 2010-11-30 06:03:28 UTC
I've pushed fixes for gnobots2 and gnomine
Comment 10 Robert Ancell 2010-12-06 00:42:14 UTC
Mahjongg now fixed, the remaining games are the Python games (Sudoku, Chess - these are planned to be ported to Vala) and the Seed games (Lightsoff and Swell Foop).
Comment 11 Thomas Andersen 2011-01-11 21:13:56 UTC
The seed games use clutter and i am pretty sure sudoku is using cairo for its drawing. Chess is moving to vala so I consider this bug closed.