After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 625368 - gstdatetime.c doesn't compile in VS 2008
gstdatetime.c doesn't compile in VS 2008
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.10.30
Other Windows
: Normal normal
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-07-27 06:49 UTC by Vladimir Eremeev
Modified: 2010-07-27 10:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Vladimir Eremeev 2010-07-27 06:49:38 UTC 
While merging commit 4cecd73c93b0728cd0e4980ed8d0940c93f9129e to the GStreamer-winbuilds, I've got compiler errors in the function gst_date_time_new_from_unix_epoch:

line 323: too many arguments to the function localtime.

this line says:
localtime(&tt, &tm);

but should be
memcpy(&tm, localtime (&tt), sizeof(struct tm));

Because localtime takes one argument and returns a pointer.
Comment 1 Thiago Sousa Santos 2010-07-27 10:30:20 UTC 
Thanks for reporting it, fixed with this commit.

commit fda35f7ac7cc181e49ce147d3a8e01171b0b9a1e
Author: Thiago Santos <thiago.sousa.santos@collabora.co.uk>
Date:   Tue Jul 27 07:21:19 2010 -0300

    gstdatetime: Fix localtime usage
    
    localtime only takes one parameter and returns a statically
    allocated tm struct. Use it correctly.
    
    Fixes #625368