GNOME Bugzilla – Bug 625189
Problems with plugin lyrics in parser of Terra.
Last modified: 2018-05-24 15:23:59 UTC
Hi, I found and fix the problem with plugin lyrics of terra, so when try show lyrics of song that have character "'", the text is show hardcode html code. Eg: the song used for test in terra parser was "Lighthouse family, Ocean Drive" follow the patch.
Created attachment 166489 [details] [review] Fixing incorrect show of html char when using lyrics of terra.com.br Fixing incorrect show of html char when using lyrics of terra.com.br
Well, thanks, but you seem to have rewritten the code without explaining what you're changing or why. I can't reproduce the problem you describe either.
So, when trying get the lyrics that have character "'" is showing "'". following the screenshot.
Created attachment 166604 [details] sample of incorrect view.
The unescape code works for that character both before and after your changes. Maybe you just need to remove a cached lyrics file you downloaded with an older version where the unescape code didn't work properly?
yes, didn't works. but when using with patch works fine.
Jonathan was suggesting that you double check if it works or not without your patch, and that you make sure you don't have a cached lyrics file before checking whether it works or not without your patch.
yes, i understand. however, i tried with original version and request <refresh>. but didn't works. and my connection is directly with internet, don't using proxy cache.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/953.