After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624757 - Check for TFP usage after actually setting the pixmap
Check for TFP usage after actually setting the pixmap
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks: 624571
 
 
Reported: 2010-07-19 17:12 UTC by drago01
Modified: 2010-07-30 14:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Check for TFP usage after actually setting the pixmap (1.66 KB, patch)
2010-07-19 17:13 UTC, drago01
committed Details | Review

Description drago01 2010-07-19 17:12:40 UTC
See patch, this is required clutter 1.4 to avoid showing a wrong message.
Comment 1 drago01 2010-07-19 17:13:14 UTC
Created attachment 166169 [details] [review]
Check for TFP usage after actually setting the pixmap

Starting with clutter 1.4 clutter / cogl only knows whether TFP is in use after
setting the pixmap, so doing the check before setting the pixmap will just
lead to a wrong message.

https://bugzilla.gnome.org/show_bug.cgi?id=624571
Comment 2 drago01 2010-07-22 15:50:31 UTC
See http://bugzilla.clutter-project.org/show_bug.cgi?id=2236 for reference.
Comment 3 Owen Taylor 2010-07-30 12:38:03 UTC
Review of attachment 166169 [details] [review]:

Looks fine. (The whole warning is in dubious taste - it should likely only warn once or not at all.)

 - You might want to strip down to one bug reference in the commit message
 - A comment explaining that the clutter call only works after setting the pixmap would be a good idea.
Comment 4 drago01 2010-07-30 14:21:44 UTC
(In reply to comment #3)
> Review of attachment 166169 [details] [review]:
> 
> Looks fine. (The whole warning is in dubious taste - it should likely only warn
> once or not at all.)

Yeah it is not like it should be printed out that often in real world scenarios,
but it it might be helpful to identify why things are "very slow" (in case we hit a driver bug or some other weirdness).

>  - You might want to strip down to one bug reference in the commit message
>  - A comment explaining that the clutter call only works after setting the
> pixmap would be a good idea.

OK.
Comment 5 drago01 2010-07-30 14:22:05 UTC
Attachment 166169 [details] pushed as ce1ffa4 - Check for TFP usage after actually setting the pixmap