After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 623654 - qtdemux: Fix order of bitrates in 'btrt' atom
qtdemux: Fix order of bitrates in 'btrt' atom
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-07-06 07:53 UTC by Arun Raghavan
Modified: 2010-07-06 09:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
qtdemux: Fix order of bitrates in 'btrt' atom (1.23 KB, patch)
2010-07-06 07:53 UTC, Arun Raghavan 		none Details | Review
qtdemux: Fix order of bitrates in 'btrt' atom (1.69 KB, patch)
2010-07-06 08:40 UTC, Arun Raghavan 		committed Details | Review

Description Arun Raghavan 2010-07-06 07:53:26 UTC 
I got this wrong. :/ Attaching a fix.
Comment 1 Arun Raghavan 2010-07-06 07:53:30 UTC 
Created attachment 165329 [details] [review]
qtdemux: Fix order of bitrates in 'btrt' atom

There seems to be a bug in libmp4v2 that generates a MPEG4BitRateBox as
(bufferSizeDB, avgBitrate, maxBitrate) instead of (bufferSizeDB,
maxBitrate, avgBitrate), according to the spec. I used the mp4file
output while writing this code, so the order is wrong. This patches
fixes that.
Comment 2 Arun Raghavan 2010-07-06 08:40:47 UTC 
Created attachment 165337 [details] [review]
qtdemux: Fix order of bitrates in 'btrt' atom

There seems to be a bug in libmp4v2 that generates a MPEG4BitRateBox as
(bufferSizeDB, avgBitrate, maxBitrate) instead of (bufferSizeDB,
maxBitrate, avgBitrate), according to the spec. I used the mp4file
output while writing this code, so the order is wrong. This patches
fixes that.
Comment 3 Arun Raghavan 2010-07-06 08:41:41 UTC 
Attaching updated patch to handle bad muxers which write the avg. and max. bitrates swapped.
Comment 4 Tim-Philipp Müller 2010-07-06 09:34:55 UTC 
Committed, thanks (with minor style changes):

commit 8aed3176ce65a1963d1b2bea8b9ed110714ca4e2
Author: Arun Raghavan <arun.raghavan@collabora.co.uk>
Date:   Tue Jul 6 13:21:19 2010 +0530

    qtdemux: Fix order of bitrates in 'btrt' atom
    
    There seems to be a bug in libmp4v2 that generates a MPEG4BitRateBox as
    (bufferSizeDB, avgBitrate, maxBitrate) instead of (bufferSizeDB,
    maxBitrate, avgBitrate), according to the spec. I used the mp4file
    output while writing this code, so the order is wrong. This patches
    fixes that.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=623654