After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 621951 - Should use at-spi2 instead at-spi
Should use at-spi2 instead at-spi
Status: RESOLVED FIXED
Product: dasher
Classification: Applications
Component: general
4.11
Other All
: Normal normal
: ---
Assigned To: Patrick Welche
dasher-maint
Depends on:
Blocks: 619734
 
 
Reported: 2010-06-18 01:14 UTC by Javier Jardón (IRC: jjardon)
Modified: 2013-01-25 17:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Untested AT-SPI2 patch (12.03 KB, patch)
2011-10-02 10:34 UTC, Seán de Búrca
needs-work Details | Review
Updated patch with linking (12.08 KB, patch)
2012-05-01 09:05 UTC, Seán de Búrca
none Details | Review

Description Javier Jardón (IRC: jjardon) 2010-06-18 01:14:09 UTC
Dasher should depend on the new a11y framework

at-spi2-core and at-spi2-atk instead at-spi

More info here: 
http://live.gnome.org/Accessibility/GNOME3
http://live.gnome.org/Accessibility/BonoboDeprecation
Comment 1 André Klapper 2010-07-02 13:19:00 UTC
Is it planned to work on this? It is required for GNOME3 which will be soon.
Comment 2 Patrick Welche 2010-08-18 15:19:01 UTC
Yes, I thought I would start with

http://git.gnome.org/browse/at-spi2-core/commit/?id=ccbc1b958968d210f26b471abb751995f70143f5

(Note that dasher only uses bonobo for speech, and that at-spi2 has no cspi equivalent - so, we are well aware of what is going on, but the bug sounds more straight forward than it is - and more major than it actually is. Talking of speech: speech-dispatcher or OpenTTs anyone?)
Comment 3 André Klapper 2010-08-18 15:23:54 UTC
Currently OpenTTS, but you could ask in #a11y or on the mailing list?
Comment 4 Patrick Welche 2010-10-15 15:16:04 UTC
It seems to have changed back to SpeechDispatcher... Just in case there weren't enough moving targets, glib-dbus -> gio
Comment 5 André Klapper 2010-10-15 16:38:56 UTC
glib-dbus is not a gnome3.0 requirement.
Comment 6 6warez 2010-12-04 17:22:49 UTC
while i command dasher the following message and warnings are coming and the application starts
what is the problem and how to solve this?
please help me...

** Message: Opening GUI file: /usr/share/dasher/dasher.traditional.ui
** Message: Opening GUI file: /usr/share/dasher/dasher.preferences.ui

** (dasher:4888): WARNING **: AT_SPI_REGISTRY was not started at session startup.

** (dasher:4888): WARNING **: Could not locate registry
** Message: Could not initialise SPI - accessibility options disabled
Comment 7 Alejandro Piñeiro Iglesias (IRC: infapi00) 2011-05-12 18:50:49 UTC
Patrick, you have lost some accessibility meetings, but FYI.

In relation to a C api in order to create an AT you can use libatspi. Current python bindings for at-spi2 are created using gobject introspection on this library.

It is not C-SPI compatible, but would allow to create a C AT compatible with at-spi2. So solving this issue for AT-SPI2 would involve moving to a new C API instead of a language migration.
Comment 8 Seán de Búrca 2011-10-02 10:34:43 UTC
Created attachment 198001 [details] [review]
Untested AT-SPI2 patch

I took a crack at porting dasher to at-spi2. I'm not sure what's meant by the API not being C-SPI compatible, as it seemed that most things were generally the same. That said, this patch is untested. I haven't gotten it to link, even, though everything seems to be in place.
Comment 9 André Klapper 2011-11-06 18:18:39 UTC
Could this patch get a review, please?
Comment 10 Seán de Búrca 2012-02-25 20:56:49 UTC
Any chance I could get some feedback on this patch?
Comment 11 Patrick Welche 2012-02-26 12:04:09 UTC
Could you try at least compiling and linking it first?

(In the meantime I have written at-spi2-* packages for pkgsrc.org, which have been committed a few weeks ago, so at least I have a libatspi. I am still working on removing all the various editors. After that I will write the equivalent of an external editor using libatspi. A quick look at the patch just looks like replacing old libcspi function names with libatspi...)
Comment 12 Seán de Búrca 2012-05-01 09:05:34 UTC
Created attachment 213174 [details] [review]
Updated patch with linking

The email about your comment must have gotten lost in the shuffle. I figured out the linking problem and have modified the patch accordingly. A very, very quick test seems to show it's mostly working, as far as I can tell.
Comment 13 Patrick Welche 2013-01-17 12:50:38 UTC
I have finally removed enough spaghetti to add at-spi2 support.
Comment 14 Patrick Welche 2013-01-25 17:44:32 UTC
After

http://git.gnome.org/browse/dasher/commit/?id=8857b4e8c602b42bb696f1f106f276bd5ea9156a

at-spi2 support is function, in addition to Xtst and cspi.