GNOME Bugzilla – Bug 619328
git-bz push miss detects URLs as cross references
Last modified: 2010-06-05 14:32:07 UTC
While pushing http://git.gnome.org/browse/gnome-shell/commit/?id=9fca747ef439a94f537b0b8923ae30a469841f7c using git-bz push, the patch got skipped with a message like: ------------------ 9455554..ce3f003 master -> master Skipping cross-reference 'see https://developer.mozilla.org/en/SpiderMonkey/JSAPI_Reference/JS_MaybeGC https://bugzilla.gnome.org/show_bug.cgi?id=614725' ------------------
The following fix has been pushed: 14250be Handle 'see <url> <bug reference>'
Created attachment 162807 [details] [review] Handle 'see <url> <bug reference>' The code that was supposed to handle 'See Mozilla bug http://bugzilla.mozilla.org/show_bug.cgi?...' as a cross reference was also detecting 'See https://developer.mozilla.org/en/SpiderMonkey/JSAPI_Reference/JS_MaybeGC https://bugzilla.gnome.org/show_bug.cgi?id=614725' As a cross-reference. Fix by requiring the "intervening words" not to have a : or / in them, since "See <url>" is clearly standalone and something with a : or a / in it is probably an URL. Reported by Adel Gadllah