GNOME Bugzilla – Bug 618324
rtp payloader don't put the duration on their output buffers
Last modified: 2010-05-13 09:46:27 UTC
Created attachment 160787 [details] [review] basertpaudiopayload: Set duration on buffers The payloaders know the duration, but they don't put it on their output buffers. I'm attaching a patch against GstBaseRtpAudioPayload. More patches to follow.
Created attachment 160789 [details] [review] basertpaudiopayload: Add extra frame for non-complete frame lengths Some payloaders like rtpg729pay can add a shorter frame at the end of a RTP packet. We need to count it like a full frame for timestamps.
Created attachment 160790 [details] [review] celtpay: Accumulate duration of accumulated parts
The last patch seems to work around a bug in the current code. This is what the code should have done: commit 3e4bc043a567a954a84397aedb1064b0a1a7de61 Author: Wim Taymans <wim.taymans@collabora.co.uk> Date: Thu May 13 11:30:27 2010 +0200 celtpay: fix queue duration calculations Don't blindly add the durations of incomming buffers to the total queued duration because it might be invalid. Mark the total queued duration invalid when we receive an invalid incomming timestamp because that's when we lose track of the total queued duration. Fixes #618324