After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614451 - Embed page setup dialog in the print dialog
Embed page setup dialog in the print dialog
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
git master
Other Linux
: Normal enhancement
: GNOME3.0
Assigned To: EOG Maintainers
EOG Maintainers
: 628492 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-03-31 11:32 UTC by Marek Kašík
Modified: 2010-11-23 16:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch embedding page setup in the print dialog (7.67 KB, patch)
2010-03-31 11:32 UTC, Marek Kašík
needs-work Details | Review
patch embedding page setup in the print dialog (7.52 KB, patch)
2010-04-02 13:15 UTC, Marek Kašík
committed Details | Review

Description Marek Kašík 2010-03-31 11:32:43 UTC
Created attachment 157572 [details] [review]
patch embedding page setup in the print dialog

There is a possibility of embedding paper size combo and orientation
combo in the print dialog since Gtk+ 2.17.4. It is activated by calling of
gtk_print_operation_set_embed_page_setup() function.
It would be nice to have this feature in eog.

Regards

Marek
Comment 1 Felix Riemann 2010-04-01 19:47:24 UTC
Review of attachment 157572 [details] [review]:

Patch looks good to me so far. :)

One problem though:
(eog:24499): GLib-GObject-CRITICAL **: g_object_unref: assertion `G_IS_OBJECT (object)' failed

I get this after changing the paper size and then printing to it the first time.
Seems like the page setup object has a problem with the object lifetime.
Comment 2 Marek Kašík 2010-04-02 13:15:56 UTC
Created attachment 157751 [details] [review]
patch embedding page setup in the print dialog

Hi Felix,

this is modified version of the previous patch. Function eog_print_image_setup_update unreferenced given "page_setup" which was not correct.

Thanks for catching this

Marek
Comment 3 Felix Riemann 2010-04-14 19:27:33 UTC
Comment on attachment 157751 [details] [review]
patch embedding page setup in the print dialog

Thanks Marek. Just pushed this one to the repo.

commit cffc41e7b0f255cdaf82052dad83ff1539599fdb
Author: Marek Kasik <>
Date:   Fri Apr 2 15:00:26 2010 +0200

    Embed page setup in the print dialog
    
    This patch activates paper size combo and orientation combo in the
    Page Setup tab in the print dialog. It removes "Page Setup..." from
    the file menu. It also actualize paper size in Image Settings each
    time it changes. (bug 614451)
Comment 4 Felix Riemann 2010-09-01 16:02:59 UTC
*** Bug 628492 has been marked as a duplicate of this bug. ***
Comment 5 Till Kamppeter 2010-11-23 16:16:32 UTC
Reported this problem also to other GTK-based programs:

f-spot: https://bugzilla.gnome.org/show_bug.cgi?id=635611
GIMP: https://bugzilla.gnome.org/show_bug.cgi?id=635615
shotwell: http://trac.yorba.org/ticket/2733