After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612727 - Does not compile with -DGSEAL_ENABLE
Does not compile with -DGSEAL_ENABLE
Status: RESOLVED FIXED
Product: gtk-vnc
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-vnc-maint
gtk-vnc-maint
Depends on:
Blocks: 585391
 
 
Reported: 2010-03-12 17:39 UTC by André Klapper
Modified: 2010-06-13 15:51 UTC
See Also:
GNOME target: ---
GNOME version: 2.29/2.30


Attachments
Partial patch (6.52 KB, patch)
2010-03-13 17:27 UTC, André Klapper
committed Details | Review
Final patch (1.29 KB, patch)
2010-04-10 21:54 UTC, André Klapper
rejected Details | Review

Description André Klapper 2010-03-12 17:39:05 UTC
This module does not build with -DGSEAL_ENABLE.
See http://live.gnome.org/GnomeGoals/UseGseal .

Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588339, bug 597610) needed for sealing.
Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status.

The jhbuild output posted here of course only lists the very first error when trying to compile.

vncdisplay.c: In function ‘expose_event’:
vncdisplay.c:315: error: ‘GtkWidget’ has no member named ‘window’
vncdisplay.c:323: error: ‘GtkWidget’ has no member named ‘window’
vncdisplay.c: In function ‘do_keyboard_grab’:
vncdisplay.c:412: error: ‘GtkWidget’ has no member named ‘window’
vncdisplay.c: In function ‘do_pointer_hide’:
vncdisplay.c:434: error: ‘GtkWidget’ has no member named ‘window’
vncdisplay.c: In function ‘do_pointer_show’:
vncdisplay.c:441: error: ‘GtkWidget’ has no member named ‘window’
vncdisplay.c: In function ‘do_pointer_grab’:
vncdisplay.c:461: error: ‘GtkWidget’ has no member named ‘window’
vncdisplay.c: In function ‘motion_event’:
vncdisplay.c:606: error: ‘GtkWidget’ has no member named ‘window’
vncdisplay.c:635: error: ‘GtkWidget’ has no member named ‘window’
vncdisplay.c: In function ‘on_update’:
vncdisplay.c:840: error: ‘GtkWidget’ has no member named ‘window’
vncdisplay.c: In function ‘setup_gdk_image’:
vncdisplay.c:877: error: ‘GtkWidget’ has no member named ‘window’
vncdisplay.c:880: error: ‘GtkWidget’ has no member named ‘window’
vncdisplay.c: In function ‘do_resize’:
vncdisplay.c:994: error: ‘GtkWidget’ has no member named ‘window’
vncdisplay.c: In function ‘on_get_preferred_pixel_format’:
vncdisplay.c:1028: error: ‘GtkWidget’ has no member named ‘window’
vncdisplay.c: In function ‘on_local_cursor’:
vncdisplay.c:1255: error: ‘GtkWidget’ has no member named ‘window’
vncdisplay.c: In function ‘vnc_display_close’:
vncdisplay.c:1531: error: ‘GtkWidget’ has no member named ‘window’
vncdisplay.c:1534: error: ‘GtkWidget’ has no member named ‘window’
vncdisplay.c: In function ‘vnc_display_init’:
vncdisplay.c:1950: error: ‘GtkObject’ has no member named ‘flags’
vncdisplay.c: In function ‘vnc_display_set_scaling’:
vncdisplay.c:2192: error: ‘GtkWidget’ has no member named ‘window’
make[2]: *** [libgtk_vnc_1_0_la-vncdisplay.lo] Error 1
make[2]: Leaving directory `/home/andre/svn-gnome/gtk-vnc-0.3.10/src'
make[1]: *** [all-recursive] Error 1
Comment 1 André Klapper 2010-03-13 17:27:42 UTC
Created attachment 156067 [details] [review]
Partial patch

Partial patch (bumping gtk+ requirement to 2.14), only leaving
  vncdisplay.c:1950: GTK_WIDGET_SET_FLAGS(obj, GTK_CAN_FOCUS)
left to fix, which will require gtk+ 2.19.7.
Comment 2 Daniel P. Berrange 2010-03-20 19:07:15 UTC
I've commited your patched in 

commit 8de4510cbecdf9ae21d6ed3d1437c4abdfb13593
Author: Andre Klapper <a9016009@gmx.de>
Date:   Sat Mar 20 18:54:19 2010 +0000

    Remove use of 'widget->window' in favour of gtk_widget_get_window()
    
    When building using -DGSEAL_ENABLE, the 'widget->window' field is
    not available. Instead the gtk_widget_get_window() method must be
    used
    
    * configure.ac: Bump dep on GTK to 2.14
    * src/vncdisplay.c: Switch to gtk_widget_get_window()


Will leave this bug open though, since you mention the SET_FLAGS call is still a problem
Comment 3 André Klapper 2010-04-10 21:54:26 UTC
Created attachment 158391 [details] [review]
Final patch

Ifdef'ed as you probably don't want to depend on gtk+ 2.18 yet.
Also note that I've added a section to configure.ac to avoid future breakage - if you don't like that part please drop that part when committing.
Comment 4 André Klapper 2010-06-04 14:44:37 UTC
ping - can my patch get a review/commit please?
Comment 5 André Klapper 2010-06-10 21:03:58 UTC
Daniel, can you take a look at the patch please?

We'd like to get GNOME 2.31.4 in two weeks out with gtk 2.90 so getting this fixed (and a new tarball) becomes urgent...

Thanks a lot in advance!
Comment 6 Jonh Wendell 2010-06-11 20:40:41 UTC
Just pushed a fix into master.
Comment 7 André Klapper 2010-06-13 15:51:29 UTC
Thanks a bunch!
Is a new tarball planned for the next two weeks? Would be welcome...