GNOME Bugzilla – Bug 612494
Does not compile with -DGSEAL_ENABLED
Last modified: 2010-07-19 07:07:34 UTC
This module does not build with -DGSEAL_ENABLED. See http://live.gnome.org/GnomeGoals/UseGseal . Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing. Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status. The jhbuild output posted here of course only lists the very first error when trying to compile. egg-datetime.c: In function ‘popup_position’: egg-datetime.c:828: error: ‘GtkWidget’ has no member named ‘window’ egg-datetime.c:830: error: ‘GtkWidget’ has no member named ‘allocation’ egg-datetime.c:831: error: ‘GtkWidget’ has no member named ‘allocation’ egg-datetime.c:832: error: ‘GtkWidget’ has no member named ‘allocation’ egg-datetime.c:833: error: ‘GtkWidget’ has no member named ‘allocation’ egg-datetime.c: In function ‘popup_show’: egg-datetime.c:856: error: ‘GtkWidget’ has no member named ‘window’ egg-datetime.c: In function ‘cal_popup_button_pressed’: egg-datetime.c:955: error: ‘GtkWidget’ has no member named ‘parent’ egg-datetime.c: In function ‘time_popup_button_pressed’: egg-datetime.c:1060: error: ‘GtkWidget’ has no member named ‘parent’ make[2]: *** [libeggdatetime_la-egg-datetime.lo] Error 1 make[2]: Leaving directory `/home/andre/svn-gnome/seahorse/libegg' make[1]: *** [all-recursive] Error 1
Attaching a patch that fixes all issues but GTK_WIDGET_SET_FLAGS (GTK_WINDOW (w), GTK_TOPLEVEL); in libseahorse/seahorse-widget.c:271 as I have no idea how to replace that.
Created attachment 158586 [details] [review] Patch fixing all but one issue
(In reply to comment #1) > Attaching a patch that fixes all issues but > GTK_WIDGET_SET_FLAGS (GTK_WINDOW (w), GTK_TOPLEVEL); > in libseahorse/seahorse-widget.c:271 > as I have no idea how to replace that. Why do you need this? There is not public api for this.
Review of attachment 158586 [details] [review]: Committed. I'll have a look at the one problem after I upgrade to Lucid.
Looking at my committed patch again, there is else - menu_ypos += widget->allocation.height; in libseahorse/seahorse-util.c which should have been else - menu_ypos += widget->allocation.height; + menu_ypos += allocation.height; My fault. I have corrected this in git master: http://git.gnome.org/browse/seahorse/commit/?id=964b3702ced10c59a9d13956c52054858cfa3f76
(In reply to comment #4) > I'll have a look at the one problem after I upgrade to Lucid. Any news?
ping - this is getting really urgent now for 2.31.4.
Created attachment 163680 [details] [review] 0001-Fixes-remaining-issues-for-compiling-with-DGSEAL_ENA.patch Chatting with jjardon, he has told me that it's safe to remove that line but he's not 100% sure. I have tested seahorse removing it and seems to work well. I have also fixed 2 remaining issues.
Cool, thanks. Do you also plan to look at bug 612495?
I'm reopening it because it doesn't compile without my patch yet. CC seahorse-gkr-source.lo CCLD libseahorse-gkr.la copying selected object files to avoid basename conflicts... make[2]: se sale del directorio `/home/pablo/src/gits/seahorse/gkr' Making all in pkcs11 make[2]: se ingresa al directorio `/home/pablo/src/gits/seahorse/pkcs11' CC seahorse-pkcs11-certificate.lo CC seahorse-pkcs11-certificate-props.lo seahorse-pkcs11-certificate-props.c: In function ‘seahorse_pkcs11_certificate_props_init’: seahorse-pkcs11-certificate-props.c:62: error: ‘GtkDialog’ has no member named ‘vbox’ make[2]: *** [seahorse-pkcs11-certificate-props.lo] Error 1 make[2]: se sale del directorio `/home/pablo/src/gits/seahorse/pkcs11' make[1]: *** [all-recursive] Error 1 make[1]: se sale del directorio `/home/pablo/src/gits/seahorse' make: *** [all] Error 2 *** Error during phase build of seahorse: ########## Error running make CFLAGS+="-DGSEAL_ENABLE" V=0 *** [1/1]
Created attachment 164397 [details] [review] 0001-Fixes-remaining-issues-for-compiling-with-DGSEAL_ENA.patch I cannot commit it because I don't have here my ssh key.
Created attachment 164400 [details] [review] Use GDK accessor functions instead direc access This patch is needed too to use GDK accessor functions instead direc access
Can I already commit these two patches or should I wait until seahorse is branched?
I've committed an ifdef'd version of Javier's patch. Please don't submit patches that will not build with 2.20 or current stable version.
For the records: http://git.gnome.org/browse/seahorse/commit/?id=b3af3c9c41f54f7a06233e9c014bf21bbb98a0cd