After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612494 - Does not compile with -DGSEAL_ENABLED
Does not compile with -DGSEAL_ENABLED
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
2.30.x
Other Linux
: Normal normal
: ---
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks: 585391
 
 
Reported: 2010-03-10 20:40 UTC by André Klapper
Modified: 2010-07-19 07:07 UTC
See Also:
GNOME target: 3.0
GNOME version: 2.29/2.30


Attachments
Patch fixing all but one issue (10.95 KB, patch)
2010-04-13 10:07 UTC, André Klapper
committed Details | Review
0001-Fixes-remaining-issues-for-compiling-with-DGSEAL_ENA.patch (2.43 KB, patch)
2010-06-15 14:13 UTC, Pablo Castellano (IRC: pablog)
none Details | Review
0001-Fixes-remaining-issues-for-compiling-with-DGSEAL_ENA.patch (1.76 KB, patch)
2010-06-23 14:41 UTC, Pablo Castellano (IRC: pablog)
none Details | Review
Use GDK accessor functions instead direc access (2.56 KB, patch)
2010-06-23 14:59 UTC, Javier Jardón (IRC: jjardon)
none Details | Review

Description André Klapper 2010-03-10 20:40:33 UTC
This module does not build with -DGSEAL_ENABLED.
See http://live.gnome.org/GnomeGoals/UseGseal .

Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing.
Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status.

The jhbuild output posted here of course only lists the very first error when trying to compile.

egg-datetime.c: In function ‘popup_position’:
egg-datetime.c:828: error: ‘GtkWidget’ has no member named ‘window’
egg-datetime.c:830: error: ‘GtkWidget’ has no member named ‘allocation’
egg-datetime.c:831: error: ‘GtkWidget’ has no member named ‘allocation’
egg-datetime.c:832: error: ‘GtkWidget’ has no member named ‘allocation’
egg-datetime.c:833: error: ‘GtkWidget’ has no member named ‘allocation’
egg-datetime.c: In function ‘popup_show’:
egg-datetime.c:856: error: ‘GtkWidget’ has no member named ‘window’
egg-datetime.c: In function ‘cal_popup_button_pressed’:
egg-datetime.c:955: error: ‘GtkWidget’ has no member named ‘parent’
egg-datetime.c: In function ‘time_popup_button_pressed’:
egg-datetime.c:1060: error: ‘GtkWidget’ has no member named ‘parent’
make[2]: *** [libeggdatetime_la-egg-datetime.lo] Error 1
make[2]: Leaving directory `/home/andre/svn-gnome/seahorse/libegg'
make[1]: *** [all-recursive] Error 1
Comment 1 André Klapper 2010-04-13 10:02:33 UTC
Attaching a patch that fixes all issues but
   GTK_WIDGET_SET_FLAGS (GTK_WINDOW (w), GTK_TOPLEVEL);
in libseahorse/seahorse-widget.c:271
as I have no idea how to replace that.
Comment 2 André Klapper 2010-04-13 10:07:08 UTC
Created attachment 158586 [details] [review]
Patch fixing all but one issue
Comment 3 Javier Jardón (IRC: jjardon) 2010-04-13 15:32:10 UTC
(In reply to comment #1)
> Attaching a patch that fixes all issues but
>    GTK_WIDGET_SET_FLAGS (GTK_WINDOW (w), GTK_TOPLEVEL);
> in libseahorse/seahorse-widget.c:271
> as I have no idea how to replace that.

Why do you need this?
There is not public api for this.
Comment 4 Adam Schreiber 2010-04-17 00:59:11 UTC
Review of attachment 158586 [details] [review]:

Committed.  I'll have a look at the one problem after I upgrade to Lucid.
Comment 5 André Klapper 2010-04-17 09:22:00 UTC
Looking at my committed patch again, there is
     else
    - menu_ypos += widget->allocation.height;
in libseahorse/seahorse-util.c which should have been
     else
    - menu_ypos += widget->allocation.height;
    + menu_ypos += allocation.height;

My fault. I have corrected this in git master: http://git.gnome.org/browse/seahorse/commit/?id=964b3702ced10c59a9d13956c52054858cfa3f76
Comment 6 André Klapper 2010-05-28 15:23:36 UTC
(In reply to comment #4)
> I'll have a look at the one problem after I upgrade to Lucid.

Any news?
Comment 7 André Klapper 2010-06-15 12:29:06 UTC
ping - this is getting really urgent now for 2.31.4.
Comment 8 Pablo Castellano (IRC: pablog) 2010-06-15 14:13:35 UTC
Created attachment 163680 [details] [review]
0001-Fixes-remaining-issues-for-compiling-with-DGSEAL_ENA.patch

Chatting with jjardon, he has told me that it's safe to remove that line but he's not 100% sure.

I have tested seahorse removing it and seems to work well.
I have also fixed 2 remaining issues.
Comment 9 André Klapper 2010-06-15 14:14:53 UTC
Cool, thanks. Do you also plan to look at bug 612495?
Comment 10 Pablo Castellano (IRC: pablog) 2010-06-23 14:38:59 UTC
I'm reopening it because it doesn't compile without my patch yet.

  CC     seahorse-gkr-source.lo
  CCLD   libseahorse-gkr.la
copying selected object files to avoid basename conflicts...
make[2]: se sale del directorio `/home/pablo/src/gits/seahorse/gkr'
Making all in pkcs11
make[2]: se ingresa al directorio `/home/pablo/src/gits/seahorse/pkcs11'
  CC     seahorse-pkcs11-certificate.lo
  CC     seahorse-pkcs11-certificate-props.lo
seahorse-pkcs11-certificate-props.c: In function ‘seahorse_pkcs11_certificate_props_init’:
seahorse-pkcs11-certificate-props.c:62: error: ‘GtkDialog’ has no member named ‘vbox’
make[2]: *** [seahorse-pkcs11-certificate-props.lo] Error 1
make[2]: se sale del directorio `/home/pablo/src/gits/seahorse/pkcs11'
make[1]: *** [all-recursive] Error 1
make[1]: se sale del directorio `/home/pablo/src/gits/seahorse'
make: *** [all] Error 2
*** Error during phase build of seahorse: ########## Error running make  CFLAGS+="-DGSEAL_ENABLE" V=0 *** [1/1]
Comment 11 Pablo Castellano (IRC: pablog) 2010-06-23 14:41:03 UTC
Created attachment 164397 [details] [review]
0001-Fixes-remaining-issues-for-compiling-with-DGSEAL_ENA.patch

I cannot commit it because I don't have here my ssh key.
Comment 12 Javier Jardón (IRC: jjardon) 2010-06-23 14:59:39 UTC
Created attachment 164400 [details] [review]
Use GDK accessor functions instead direc access

This patch is needed too to use GDK accessor functions instead direc access
Comment 13 Pablo Castellano (IRC: pablog) 2010-07-13 15:27:09 UTC
Can I already commit these two patches or should I wait until seahorse is branched?
Comment 14 Adam Schreiber 2010-07-19 01:06:20 UTC
I've committed an ifdef'd version of Javier's patch. Please don't submit patches that will not build with 2.20 or current stable version.