After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612482 - Does not compile with -DGSEAL_ENABLE
Does not compile with -DGSEAL_ENABLE
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
Depends on:
Blocks: 585391
 
 
Reported: 2010-03-10 20:30 UTC by André Klapper
Modified: 2011-11-11 10:03 UTC
See Also:
GNOME target: ---
GNOME version: 2.29/2.30


Attachments
Patch (6.63 KB, patch)
2010-04-22 09:21 UTC, André Klapper
committed Details | Review
Patch (7.67 KB, patch)
2010-06-20 09:51 UTC, André Klapper
committed Details | Review

Description André Klapper 2010-03-10 20:30:54 UTC
This module does not build with -DGSEAL_ENABLED.
See http://live.gnome.org/GnomeGoals/UseGseal .

Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing.
Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status.

The jhbuild output posted here of course only lists the very first error when trying to compile.

gsm_color_button.c: In function ‘render’:
gsm_color_button.c:265: error: ‘GtkWidget’ has no member named ‘window’
gsm_color_button.c:290: error: ‘GtkWidget’ has no member named ‘window’
gsm_color_button.c: In function ‘gsm_color_button_size_allocate’:
gsm_color_button.c:471: error: ‘GtkWidget’ has no member named ‘allocation’
gsm_color_button.c:474: error: ‘GtkObject’ has no member named ‘flags’
gsm_color_button.c:476: error: ‘GtkWidget’ has no member named ‘window’
gsm_color_button.c: In function ‘gsm_color_button_drag_data_received’:
gsm_color_button.c:515: error: ‘GtkSelectionData’ has no member named ‘length’
gsm_color_button.c:521: error: ‘GtkSelectionData’ has no member named ‘length’
gsm_color_button.c:528: error: ‘GtkSelectionData’ has no member named ‘data’
gsm_color_button.c: In function ‘gsm_color_button_drag_data_get’:
gsm_color_button.c:584: error: ‘GtkSelectionData’ has no member named ‘target’
gsm_color_button.c: In function ‘dialog_ok_clicked’:
gsm_color_button.c:662: error: ‘GtkColorSelectionDialog’ has no member named ‘colorsel’
gsm_color_button.c: In function ‘gsm_color_button_clicked’:
gsm_color_button.c:717: error: ‘GtkObject’ has no member named ‘flags’
gsm_color_button.c:728: error: ‘GtkColorSelectionDialog’ has no member named ‘ok_button’
gsm_color_button.c:730: error: ‘GtkColorSelectionDialog’ has no member named ‘cancel_button’
gsm_color_button.c:738: error: ‘GtkColorSelectionDialog’ has no member named ‘colorsel’
gsm_color_button.c:742: error: ‘GtkColorSelectionDialog’ has no member named ‘colorsel’
make[2]: *** [gsm_color_button.o] Error 1
make[2]: Leaving directory `/home/andre/svn-gnome/gnome-system-monitor/src'
make[1]: *** [all-recursive] Error 1
Comment 1 André Klapper 2010-04-22 09:21:06 UTC
Created attachment 159316 [details] [review]
Patch

Patch that is very likely wrong when it comes to the Color Selection Dialog handlers for OK and CANCEL, but something to start from.
Comment 2 Javier Jardón (IRC: jjardon) 2010-06-17 19:04:14 UTC
Review of attachment 159316 [details] [review]:

looks good, some minor comments

::: src/gsm_color_button.c
@@ +288,3 @@
   gdk_cairo_set_source_color (cr, color);
   }
+  gdk_drawable_get_size (gtk_widget_get_window (widget), &width, &height);

You can store the window var here

@@ +518,2 @@
   guint16 *dropped;
+  if (gtk_selection_data_get_length (selection_data) < 0)

You can store the length var here

@@ +744,3 @@
   gtk_color_selection_set_previous_color (GTK_COLOR_SELECTION
 
+					  (gtk_color_selection_dialog_get_color_selection (color_dialog)),

You can store the color selection here
Comment 3 Javier Jardón (IRC: jjardon) 2010-06-20 04:10:23 UTC
Comment on attachment 159316 [details] [review]
Patch

comitted with my comments and some indentation fixes.

commit 9a01aae12432c7934c93de37490f7a1f6358d9f1
Comment 4 Javier Jardón (IRC: jjardon) 2010-06-20 04:11:07 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release.

Thanks André!
Comment 5 André Klapper 2010-06-20 09:35:12 UTC
Fixed for CFLAGS=-DGSEAL_ENABLE, not fixed for CXXFLAGS=-DGSEAL_ENABLE.
Reopening (and thanks to fredp for kind of reminding me about this).
Comment 6 André Klapper 2010-06-20 09:51:47 UTC
Created attachment 164113 [details] [review]
Patch
Comment 7 Javier Jardón (IRC: jjardon) 2010-06-20 14:45:58 UTC
Comment on attachment 164113 [details] [review]
Patch

looks good to me
Comment 8 André Klapper 2010-06-20 16:54:44 UTC
Comment on attachment 164113 [details] [review]
Patch

Committed as http://git.gnome.org/browse/gnome-system-monitor/commit/?id=d6e9e6576d3bf06904d7abe19e4d9e5a72d4be23 (and another cleanup afterwards)