After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 611693 - Doesn't like submodules
Doesn't like submodules
Status: RESOLVED FIXED
Product: git-bz
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: git-bz-maint
git-bz-maint
Depends on:
Blocks:
 
 
Reported: 2010-03-03 11:53 UTC by Benjamin Otte (Company)
Modified: 2010-06-05 14:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Pass --ignore-submodules when checking uncommitted changes (1.14 KB, patch)
2010-06-05 14:15 UTC, Owen Taylor
committed Details | Review

Description Benjamin Otte (Company) 2010-03-03 11:53:49 UTC
When the GStreamer common submodule has been updated, "git-bz attach" (probably other commands, too, I didn't try) fails to run and errors out with:
"Cannot add bug reference to commit message(s); You must commit (or stash) all changes first"
Of course, there is nothing to commit or stash.

A workaround is to go into the submodule and checkout the expected version, so that git diff doesn't complain anymore.

I suppose the fix is to pass --ignore-submodules in the right places?
Comment 1 Owen Taylor 2010-06-05 14:15:50 UTC
The following fix has been pushed:
2ad51d7 Pass --ignore-submodules when checking uncommitted changes
Comment 2 Owen Taylor 2010-06-05 14:15:53 UTC
Created attachment 162806 [details] [review]
Pass --ignore-submodules when checking uncommitted changes

When we check for uncommitted changes prior to adding URLs to
to commit messages we should ignore submodules, since they don't
affect the rebase xprocess we use to add URLs.

Reported by Benjamin Otte