After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 611176 - Logo/button plugins should handle text better
Logo/button plugins should handle text better
Status: RESOLVED INCOMPLETE
Product: GIMP
Classification: Other
Component: Script-Fu
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2010-02-26 13:12 UTC by Lloyd Wood
Modified: 2010-03-03 15:37 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Lloyd Wood 2010-02-26 13:12:39 UTC
I've been playing with the Create Button/Logo plugins. These do not handle the following cases well:

- no text, when you want to render the background, but not any text. it seems the empty text field is not surrounded by quotes in a shell script.

- only spaces in the text string, to get a background of a specific size overwhich the spaces are overlaid. Again, quoting the string seems to be lacking.

- handling multiple lines of text. \n isn't supported for returns. A larger text box allowing multiple lines of text, and mapping hard returns to \n, is required.

All of these are nicely demonstrated by Basic I, which throws up an error alert guessing about layers when given an empty text field.

Also, the default white-on-black of Chalk leads to a black window, no text visible.
Comment 1 Michael Schumacher 2010-02-26 13:20:23 UTC
Do you want to work on this? I doubt that anyone else will find much time for scripts that are considered a bit less-than-important for GIMP's main target audience.
Comment 2 Lloyd Wood 2010-02-26 13:35:31 UTC
These scripts are on the gimp menu, and are visible to all GIMP users. I found their output useful, and would not have found or used them if they were not on the menu.

Having said that, deprecating the scripts and removing them from the menus instead of fixing some basic scripting quoting errors would imo be the wrong thing to do.

I looked at developing for GIMP. I found:
http://www.gimp.org/source/howtos/stable-cvs-build.html
which says GIMP is in CVS. While
http://developer.gimp.org/cvs.html
says that it's not. That's probably a separate documentation bug. (Bug 580119 - open eight months now, I see.) I haven't been able to find any bugs describing the reasons for moving from cvs, which I know well, to git, which I don't.

I will not be spending further time on this issue.
Comment 3 Sven Neumann 2010-03-02 18:15:56 UTC
The main purpose of these scripts is to serve as examples for what can be done with the scripting language. If you don't want to provide patches for improving them, then we can as well close this report.
Comment 4 Lloyd Wood 2010-03-02 19:20:03 UTC
Sven,

the examples of what can be done with the scripting language are pretty poor examples if they don't even quote around variables when required. That's pretty much the #1 basic scripting (and, often, security...) error. They're not just examples, they're integral to the GIMP user interface and a demonstration of the power of scripting. And as programming examples, they can clearly be improved.

The bug report is valid. Your threatening to close it because I'm not going to work on it further - despite reporting the problem and looking into developing for GIMP in good faith, which got as far as discovering the available developer documentation does not remotely reflect reality, at which point I realised my time was being wasted - says much about the GIMP and GNOME development process, such as it is.

Perhaps you expect me to update your developer documentation for you as well? If so, you might want to explain why was CVS dumped for subversion, and then subversion dumped for git.
Comment 5 Michael Schumacher 2010-03-02 21:35:12 UTC
(In reply to comment #4)

> Perhaps you expect me to update your developer documentation for you as well?

As a matter of fact, yes. The websites are kept in git as well, and anyone can provide patches. A useful change might be to remove the cvs page - how did you end up there anyways, I thought I had removed all references on www.gimp.org?

> If so, you might want to explain why was CVS dumped for subversion, and then
> subversion dumped for git.

We're using the GNOME repository, and GNOME has move from CVS to Subversion to Git.
Comment 6 Sven Neumann 2010-03-03 12:25:39 UTC
(In reply to comment #4)
> Sven,
> 
> the examples of what can be done with the scripting language are pretty poor
> examples if they don't even quote around variables when required. That's pretty
> much the #1 basic scripting (and, often, security...) error.

That is so ridiculous. You are making assumptions about the GIMP scripting language here that clearly show that you did not even look at the script.

> They're not just
> examples, they're integral to the GIMP user interface and a demonstration of
> the power of scripting. And as programming examples, they can clearly be
> improved.

Feel free to do that then and send us a patch. But since you stated that you are not willing to do that, we are closing this report so that it doesn't clutter our bug database. There is nothing that can't be improved. So there is really no point in having a bug report that just says that something could be improved.
Comment 7 Lloyd Wood 2010-03-03 12:54:15 UTC
Sven,

> So there is really no point in having a bug report that just
> says that something could be improved.

That is not what was reported. I described exactly what was wrong, and exactly how to reproduce the error. That's all that's needed for a valid bug report. I don't need to dive into Scheme in detail to provide that useful information.

I'm impressed at how quickly you've managed to dissuade me from contributing to or using GIMP. Do you do this to all your users?

(Michael@4: google.)
Comment 8 Sven Neumann 2010-03-03 13:39:20 UTC
Can you please stop reopening this report? It's not your position to decide which reports are kept open and which aren't.
Comment 9 Martin Nordholts 2010-03-03 15:37:08 UTC
Hi Lloyd

I want to personally thank you for spending time on helping us improve GIMP by looking for bugs, even though it might not be obvious, it is appreciated.

However, insisting on reopening this bug report doesn't help us, it only wastes our time.

Thanks in advance for your understanding.

Regards,
Martin