After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 610346 - Confusion between GtkWindow:allow-grow and GtkWindow:resizable
Confusion between GtkWindow:allow-grow and GtkWindow:resizable
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.90.x
Other All
: Normal minor
: ---
Assigned To: gtk-bugs
gtk-bugs
deprecations
Depends on:
Blocks: 597756
 
 
Reported: 2010-02-18 11:25 UTC by Alberto Garcia
Modified: 2010-07-02 19:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Deprecate GtkWindow:allow-grow and GtkWindow:allow-shrink (1.61 KB, patch)
2010-06-15 20:54 UTC, Javier Jardón (IRC: jjardon)
none Details | Review
Deprecate GtkWindow:allow-grow and GtkWindow:allow-shrink.v2 (1.46 KB, patch)
2010-07-01 03:19 UTC, Javier Jardón (IRC: jjardon)
none Details | Review
Remove GtkWindow:allow-grow and GtkWindow::allow_shrink (4.89 KB, patch)
2010-07-01 03:20 UTC, Javier Jardón (IRC: jjardon)
none Details | Review
Deprecate GtkWindow:allow-grow and GtkWindow:allow-shrink.v3 (1.96 KB, patch)
2010-07-02 16:09 UTC, Javier Jardón (IRC: jjardon)
none Details | Review
Deprecate GtkWindow:allow-grow and GtkWindow:allow-shrink.v3 (1.96 KB, patch)
2010-07-02 16:10 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review
Remove GtkWindow:allow-grow and GtkWindow::allow_shrink.v2 (6.16 KB, patch)
2010-07-02 16:11 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review

Description Alberto Garcia 2010-02-18 11:25:56 UTC
I can't see any difference between GtkWindow:allow-grow and
GtkWindow:resizable.

I imagine that they used to be different some time in the past, but
right now the code is exactly the same, they both modify
window->allow_grow

http://git.gnome.org/browse/gtk+/tree/gtk/gtkwindow.c#n1104

http://git.gnome.org/browse/gtk+/tree/gtk/gtkwindow.c#n990

I think that one of them should be marked as deprecated, or at least
the documentation should be a bit clearer about this fact.
Comment 1 Matthias Clasen 2010-02-23 17:10:45 UTC
That is why gtk_window_set_policy is deprecated.
Comment 2 Alberto Garcia 2010-02-24 00:26:04 UTC
So shouldn't the properties be deprecated too?
Comment 3 Javier Jardón (IRC: jjardon) 2010-06-15 20:54:39 UTC
Created attachment 163724 [details] [review]
Deprecate GtkWindow:allow-grow and GtkWindow:allow-shrink
Comment 4 Javier Jardón (IRC: jjardon) 2010-07-01 03:19:22 UTC
Created attachment 165008 [details] [review]
Deprecate GtkWindow:allow-grow and GtkWindow:allow-shrink.v2

Updated patch using proper documentation comments
Comment 5 Javier Jardón (IRC: jjardon) 2010-07-01 03:20:25 UTC
Created attachment 165009 [details] [review]
Remove GtkWindow:allow-grow and GtkWindow::allow_shrink

This is for master (GTK+3) only
Comment 6 Matthias Clasen 2010-07-02 14:17:04 UTC
Review of attachment 165008 [details] [review]:

Could we use the new G_PARAM_DEPRECATED flag here ?
Comment 7 Matthias Clasen 2010-07-02 14:18:24 UTC
Review of attachment 165009 [details] [review]:

It might make sense to rename the struct field to resizable too, to match the property name
Comment 8 Javier Jardón (IRC: jjardon) 2010-07-02 16:09:25 UTC
Created attachment 165122 [details] [review]
Deprecate GtkWindow:allow-grow and GtkWindow:allow-shrink.v3

Rename allow_grow -> resizable
Comment 9 Javier Jardón (IRC: jjardon) 2010-07-02 16:10:34 UTC
Created attachment 165123 [details] [review]
Deprecate GtkWindow:allow-grow and GtkWindow:allow-shrink.v3

Use G_PARAM_DEPRECATED
Comment 10 Javier Jardón (IRC: jjardon) 2010-07-02 16:11:24 UTC
Created attachment 165124 [details] [review]
Remove GtkWindow:allow-grow and GtkWindow::allow_shrink.v2

Rename allow_grow -> resizable
Comment 11 Matthias Clasen 2010-07-02 17:21:59 UTC
Review of attachment 165123 [details] [review]:

looks good
Comment 12 Matthias Clasen 2010-07-02 17:22:40 UTC
Review of attachment 165124 [details] [review]:

looks good
Comment 13 Javier Jardón (IRC: jjardon) 2010-07-02 19:56:55 UTC
Comment on attachment 165123 [details] [review]
Deprecate GtkWindow:allow-grow and GtkWindow:allow-shrink.v3

gtk-2-22: commit 3805dc36052d87e4ee8b3e57c9f216671bf59b07
master: commit 1f38a7ac109562b4a2b47b50b7c72c13fd31e0e5
Comment 14 Javier Jardón (IRC: jjardon) 2010-07-02 19:57:26 UTC
Comment on attachment 165124 [details] [review]
Remove GtkWindow:allow-grow and GtkWindow::allow_shrink.v2

commit 1a03a65e36b6288f7854da30bf89b86ad3592726
Comment 15 Javier Jardón (IRC: jjardon) 2010-07-02 19:57:47 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.