Bug 609031 - Support for gnome-screensaver run as a D-Bus service
Support for gnome-screensaver run as a D-Bus service
Status: RESOLVED FIXED
Product: gnome-power-manager
Classification: Deprecated
Component: gnome-power-manager
2.29.x
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME Power Manager Maintainer(s)
GNOME Power Manager Maintainer(s)
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2010-02-04 22:34 UTC by Marc Deslauriers
Modified: 2010-03-17 16:57 UTC (History)
2 users (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to support gnome-screensaver when run as a D-Bus service (1.69 KB, patch)
2010-02-04 22:34 UTC, Marc Deslauriers 		none Details | Diff | Review
revised patch (6.83 KB, patch)
2010-02-05 17:33 UTC, Marc Deslauriers 		none Details | Diff | Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Marc Deslauriers 2010-02-04 22:34:51 UTC 
Created attachment 153047 [details] [review]
patch to support gnome-screensaver when run as a D-Bus service

Bug 609029 contains a patch for gnome-screensaver to make it run as a D-Bus service.

This patch will make gnome-power-manager work properly with gnome-screensaver when it is run as a D-Bus service.
Comment 1 Richard Hughes 2010-02-05 10:06:29 UTC 
In git master I really want to get rid of egg-dbus-proxy completely -- it's only the screensaver that needs that code now (the HAL code can be made much simpler) -- could you prepare a patch that just rips out egg-dbus-proxy from gpm-screensaver.c and fix your bug at the same time please? Thanks.
Comment 2 Richard Hughes 2010-02-05 10:14:32 UTC 
commit 9d6e266bf65f53282bd8e0328860bc71e24d2ccd
Author: Richard Hughes <richard@hughsie.com>
Date:   Fri Feb 5 10:13:40 2010 +0000

    trivial: do not use EggDbusProxy in GpmBrightnessHal
Comment 3 Marc Deslauriers 2010-02-05 17:33:57 UTC 
Created attachment 153097 [details] [review]
revised patch

Here is a revised patch, thanks!
Comment 4 Martin Pitt 2010-03-17 10:53:17 UTC 
Setting back from needsinfo since an updated patch was provided.
Comment 5 Richard Hughes 2010-03-17 12:56:13 UTC 
Looks good, please commit! Thanks.
Comment 6 Martin Pitt 2010-03-17 16:57:58 UTC 
Committed on behalf of Marc.
Note You need to log in before you can comment on or make changes to this bug.