After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 608104 - Use clear icon inside password entry
Use clear icon inside password entry
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
: 606133 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-01-25 23:24 UTC by Michael Monreal
Modified: 2011-08-29 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot (5.75 KB, image/png)
2010-01-25 23:24 UTC, Michael Monreal
  Details
http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/clear-button-608104 (26.18 KB, patch)
2010-03-16 15:35 UTC, Guillaume Desmottes
reviewed Details | Review

Description Michael Monreal 2010-01-25 23:24:47 UTC
Created attachment 152273 [details]
Screenshot

The password entry in the accounts window is followed by a clear button. It would be nicer to use the entry-integrated clear button, as nautilus uses for example.
Comment 1 Guillaume Desmottes 2010-02-08 15:11:04 UTC
Is there a GNOME consensus about this question?
Comment 2 Michael Monreal 2010-02-08 15:52:18 UTC
I am not aware of any official GNOME goal etc related to this but as most apps that are part of the desktop make use of this now it seems like an obvious choice.
Comment 3 Guillaume Desmottes 2010-03-10 15:51:52 UTC
Agreed, Cannonical's usability testing demonstrated that users were confused by having the clear button as a separated button.
Comment 4 Guillaume Desmottes 2010-03-16 15:35:41 UTC
Created attachment 156273 [details] [review]
http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/clear-button-608104

 libempathy-gtk/empathy-account-widget-aim.ui       |   35 +------
 libempathy-gtk/empathy-account-widget-groupwise.ui |   63 ++++---------
 libempathy-gtk/empathy-account-widget-icq.ui       |   35 +------
 libempathy-gtk/empathy-account-widget-jabber.ui    |   29 +-----
 libempathy-gtk/empathy-account-widget-msn.ui       |   63 ++++---------
 libempathy-gtk/empathy-account-widget-private.h    |    1 -
 libempathy-gtk/empathy-account-widget-sip.c        |    1 -
 libempathy-gtk/empathy-account-widget-sip.ui       |   40 --------
 libempathy-gtk/empathy-account-widget-yahoo.ui     |   35 +------
 libempathy-gtk/empathy-account-widget.c            |  102 ++++++++------------
 10 files changed, 93 insertions(+), 311 deletions(-)
Comment 5 Guillaume Desmottes 2010-03-16 15:36:29 UTC
*** Bug 606133 has been marked as a duplicate of this bug. ***
Comment 6 Danielle Madeley 2010-03-30 10:21:18 UTC
Review of attachment 156273 [details] [review]:

Looks fine to me.
Comment 7 Guillaume Desmottes 2010-03-30 10:53:41 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.