After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 607403 - rtpaudiopayload: ptime is in milli-seconds, convert to nanosecs
rtpaudiopayload: ptime is in milli-seconds, convert to nanosecs
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal blocker
: 0.10.26
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-01-19 02:58 UTC by Olivier Crête
Modified: 2010-01-21 09:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rtpaudiopayload: ptime is in milli-seconds, convert to nanosecs (1.10 KB, patch)
2010-01-19 02:58 UTC, Olivier Crête
accepted-commit_now Details | Review
basertppayload: ptime should be in nanoseconds (1.49 KB, patch)
2010-01-19 19:45 UTC, Olivier Crête
none Details | Review
basertppayload: ptime/maxptime should be unsigned (1.53 KB, patch)
2010-01-19 19:46 UTC, Olivier Crête
none Details | Review
rtpg729pay: ptime should is in nanoseconds (1.82 KB, patch)
2010-01-19 19:46 UTC, Olivier Crête
none Details | Review

Description Olivier Crête 2010-01-19 02:58:17 UTC
The ptime is stored in ms, it must be converted to ns for rtpbaseaudiopaylod to work.

That said, maybe I'm wrong and it should be stored in NS in rtpbasepayload.

Also, second question, right now ptime and maxptime are of type "int" in the caps, maybe they should be "uint" instead...
Comment 1 Olivier Crête 2010-01-19 02:58:18 UTC
Created attachment 151732 [details] [review]
rtpaudiopayload: ptime is in milli-seconds, convert to nanosecs
Comment 2 Wim Taymans 2010-01-19 12:15:15 UTC
It should be stored in ns, like all other ptime values IMO.
Comment 3 Wim Taymans 2010-01-19 12:17:29 UTC
ouch, it is in ms, documented in the .h file and of guint size.. Guess we need to keep it ms then.
Comment 4 Olivier Crête 2010-01-19 14:23:09 UTC
Well, its not released, so I guess we can still change it...
Comment 5 Olivier Crête 2010-01-19 19:45:19 UTC
Created attachment 151780 [details] [review]
basertppayload: ptime should be in nanoseconds
Comment 6 Olivier Crête 2010-01-19 19:46:18 UTC
Created attachment 151781 [details] [review]
basertppayload: ptime/maxptime should be unsigned
Comment 7 Olivier Crête 2010-01-19 19:46:49 UTC
Created attachment 151782 [details] [review]
rtpg729pay: ptime should is in nanoseconds
Comment 8 Wim Taymans 2010-01-21 09:50:12 UTC
commit 6c6d0e32cf227a8396c0299c1786e228fa27ea1d
Author: Olivier Crête <olivier.crete@collabora.co.uk>
Date:   Tue Jan 19 14:31:34 2010 -0500

    basertppayload: ptime/maxptime should be unsigned
    
    https://bugzilla.gnome.org/show_bug.cgi?id=607403

commit 8d2ac0b2ec386ede0e29a174b102574020072dcd
Author: Olivier Crête <olivier.crete@collabora.co.uk>
Date:   Mon Jan 18 21:16:32 2010 -0500

    basertppayload: ptime should be in nanoseconds
    
    https://bugzilla.gnome.org/show_bug.cgi?id=607403
Comment 9 Wim Taymans 2010-01-21 09:56:53 UTC
commit 9afc247906dd6c785178f10e1ec91ba825621c63
Author: Olivier Crête <olivier.crete@collabora.co.uk>
Date:   Mon Jan 18 21:15:51 2010 -0500

    rtpg729pay: ptime should is in nanoseconds
    
    https://bugzilla.gnome.org/show_bug.cgi?id=607403