GNOME Bugzilla – Bug 605023
IM Status Plugin patch for Pidgin support
Last modified: 2010-01-03 08:35:21 UTC
Created attachment 150079 [details] [review] Patch for IM Status Rhythmbox Plugin to support Pidgin Enhancement for the IM status plugin for Rhythmbox, adding support for Pidgin. There's one problem, that is Pidgin must be running before plugin is activated. Pidgin must be running all the time while plugin is activated. Otherwise, the Pidgin's IM status will default to crap (not actually crap, it's the first audio information that Pidgin receives). My first patch submission, please do correct me if anything here is wrong.
Patch looks OK to me. Does pigdin have any kind of dbus interface stability policy? I looked briefly but couldn't find one.
Could you explain more about the interface stability policy you mentioned? A bit confused here. Is it in terms of the pidgin's connection to the dbus? Or maybe pidgin's change of the dbus API?
I want to know if pidgin has any kind of policy about changing their dbus API.
I searched around for it, but found none that literally state their policy on their dbus API changing policy. But I found something that may give a clue about their tendency to change the dbus API for pidgin. According to a quote at http://developer.pidgin.im/ticket/5812, the dbus bindings are derived via some python scripts from their GObjects. It seems that their dbus binding will change with respect to their GObjectification. If there's modification with respect to the GObjects, the dbus binding will follow accordingly.
Oh well, they can hardly do worse than empathy did.. One last thing: we prefer attributing patches by full name.
Attributing patches by full name. I don't have any idea about that. Please excuse my lack of experience. Can you please advice me on how to do that? I'll submit the corrected version of the patch soon after that.
Just change your bugzilla user info to the name by which you'd like to be credited.
LOL, so sorry, been thinking too much. Okay, done.
Thanks. I've committed your patch to git master.
Welcome, and thanks again.
Just an update, I received this from Elliott Sales de Andrade (qulogic), one of Pidgin Developers, in reply to my mail. "The DBus API follows the C API. As such, it will follow the conventions we have for API/ABI compatibility. That is, no API is added until a minor version update (2.X.0) and no API is removed until a major version update (X.0.0). API might change meaning slightly, but generally only if there's a real problem. In any case, the saved status API is so large and complicated (we are aware it needs simplification) that it probably won't change until 3.0.0. But there is no specific plan, so I cannot say whether there will be significant changes in the next 6 months. It depends on when the code is ready to be used or not." So, I thought this would clarify things at least. For the 6 months time frame mentioned, it is a time frame that I stated in my mail to him, not out of the blue.
Thanks for following up on that. I'm happy as long as they have an API compatibility policy that doesn't result in random breakage because someone decided to add a new parameter to a method one day.
*** Bug 369754 has been marked as a duplicate of this bug. ***