Bug 602988 - Create a proper build system.
Create a proper build system.
Status: RESOLVED FIXED
Product: adwaita-icon-theme
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Rodney Dawes
Jakub Steiner
:
: 603414 (view as bug list)
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2009-11-26 01:49 UTC by Fabio Durán Verdugo
Modified: 2010-02-16 14:56 UTC (History)
6 users (show)

See Also:
GNOME target: 2.30.x
GNOME version: 2.29/2.30


Attachments
gnome-icon-theme build log in JHBuild (46.66 KB, application/x-gzip)
2010-01-27 16:12 UTC, Luca Ferretti
Details

Description Fabio Durán Verdugo 2009-11-26 01:49:46 UTC
I dont know is a my problem but i can install before update from git repository

fabio@OptimusPrime:~/repositorio/gnome/git/gnome-icon-theme/build$ sh autogen.sh 
/usr/bin/gnome-autogen.sh
checking for autoconf >= 2.53...
  testing autoconf2.50... not found.
  testing autoconf... found 2.64
checking for automake >= 1.9...
  testing automake-1.11... found 1.11
Checking for forbidden M4 macros...
**Warning**: I am going to run `configure' with no arguments.
If you wish to pass any to it, please specify them on the
`autogen.sh' command line.

Processing ./configure.ac
Running aclocal-1.11...
Running autoconf...
Running automake-1.11...
automake-1.11: no `Makefile.am' found for any configure output
automake-1.11: Did you forget AC_CONFIG_FILES([Makefile]) in configure.ac?
fabio@OptimusPrime:~/repositorio/gnome/git/gnome-icon-theme/build$ 

Autotools problem...
Comment 1 Christian Persch 2009-11-26 11:41:45 UTC
Same problem here.
Comment 2 Jakub Steiner 2009-11-27 22:58:28 UTC
Note the current build system is just a temporary mean. You're not supposed to call autogen from inside the build dir. Run `./create-icon-theme.sh gnome` and look for an installable icon theme in ./output/gnome
Comment 3 Jakub Steiner 2009-11-27 23:01:59 UTC
Even if we don't render at build time, Rodney you expressed the will to create a cleaner build system. Thanks :)
Comment 4 Jakub Steiner 2009-11-30 13:52:07 UTC
A quick fix/workaround for jhbuild would probably solve most of the hurt with this.
Comment 5 Frederic Peters 2009-11-30 21:21:45 UTC
*** Bug 603414 has been marked as a duplicate of this bug. ***
Comment 6 Frederic Peters 2009-11-30 22:38:50 UTC
Jakub, it looks like it would work for jhbuild if there was a minimalistic ./autogen.sh such as:

  #! /bin/sh
  ./create-icon-theme.sh gnome
  output/gnome/autogen.sh $@
Comment 7 Luca Ferretti 2009-12-01 18:21:02 UTC
(In reply to comment #6)
> Jakub, it looks like it would work for jhbuild if there was a minimalistic
> ./autogen.sh such as:
> 
>   #! /bin/sh
>   ./create-icon-theme.sh gnome
>   output/gnome/autogen.sh $@

Committed, seems to work
Comment 8 Rodney Dawes 2009-12-01 18:41:43 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > Jakub, it looks like it would work for jhbuild if there was a minimalistic
> > ./autogen.sh such as:
> > 
> >   #! /bin/sh
> >   ./create-icon-theme.sh gnome
> >   output/gnome/autogen.sh $@
> 
> Committed, seems to work

Please don't go committing things at your own discretion to master. It is disrespectful.
Comment 9 Frederic Peters 2009-12-01 23:31:54 UTC
Rodney, it was commited with good intentions, as jhbuild for both users and buildbots has been broken, and it was seen as the easiest mean to get back to something that "worked" (quotes intended) for those usages.

Of course both Luca and me are eager to have a proper build system, and wish you to come with one as soon as possible; please consider this commit as a necessary short term hack, which was made as we didn't know when a real build system would arrive. Between this, and reverting the gnome-icon-theme to the gnome-2-28 branch, the lesser of the two evils was this quick hack.
 
Thanks for your undestanding.
Comment 10 Fabio Durán Verdugo 2009-12-05 15:46:09 UTC
its works!
Comment 11 Rodney Dawes 2010-01-03 22:52:11 UTC
I've just pushed the new-build-system [1] branch. Please try it and let me know of any issues that come up. "make render" will re-render all the icons, and yes, it is slow. I want to add some magic so that it only renders SVGs that have changed, but I don't want to have to keep stamp files around either, so I'm still thinking about the best way to do that.

[1] http://git.gnome.org/browse/gnome-icon-theme/log/?h=new-build-system
Comment 12 Jakub Steiner 2010-01-07 19:09:24 UTC
I'm getting the following error when I run 'make render' after autogen:

jimmac@kratos:~/src/cvs/gnome/gnome-icon-theme new-build-system$ make render
(CDPATH="${ZSH_VERSION+.}:" && cd src && make  render) \
	|| eval `exit 1`
make[1]: Entering directory `/home/jimmac/src/cvs/gnome/gnome-icon-theme/src'
cp -a ../gnome ../gnome
cp: cannot copy a directory, `../gnome', into itself, `../gnome/gnome'
make[1]: *** [render-png] Error 1
make[1]: Leaving directory `/home/jimmac/src/cvs/gnome/gnome-icon-theme/src'
Comment 13 Rodney Dawes 2010-01-08 20:56:06 UTC
(In reply to comment #12)
> I'm getting the following error when I run 'make render' after autogen:

I've fixed the issue. I guess the fix got lost somehow in my trying to figure out git, so it wasn't included in the commit that got pushed. Should be correct now though.
Comment 14 Luca Ferretti 2010-01-27 16:12:01 UTC
Created attachment 152417 [details]
gnome-icon-theme build log in JHBuild

Rodney, it seems that master (with nuw build system merged) is unable to perform `make install`.

Here is the log. I didn't have time to investigate it, but mainly the build system creates a wrong (and mega sized) name for file to install.
Comment 15 Rodney Dawes 2010-02-16 14:56:31 UTC
There is a build system in master now.

Note You need to log in before you can comment on or make changes to this bug.