Bug 594403 - Display order is broken in some locales
Display order is broken in some locales
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
2.26.x
Other Linux
: Normal minor
: ---
Assigned To: EOG Maintainers
EOG Maintainers
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2009-09-07 18:16 UTC by Kamil Páral
Modified: 2009-09-16 09:09 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: ---


Attachments
bug demonstration (855.14 KB, video/ogg)
2009-09-07 18:16 UTC, Kamil Páral
Details

Description Kamil Páral 2009-09-07 18:16:35 UTC
Created attachment 142634 [details]
bug demonstration

In en_US locale everything works ok. But in my cs_CZ locale in some directories
the order of files shown in EOG is clearly broken (e.g. audio.svg if after
knob.png).

See the attached screencast and notice the image order number in the lower
right corner of EOG. It displays absolutely wrong number (Nautilus and ls
command shows correct ordering).
Comment 1 Felix Riemann 2009-09-07 23:02:00 UTC
Hmm, looks like a problem with the collate keys during sorting.
Need to check where the difference between the locales is.
Comment 2 Felix Riemann 2009-09-08 10:00:15 UTC
Problem was that we ignored the case when comparing the collate keys. Fixed by
commit 8d1bc77259282ce0012392b267752d87d49397e6
Author: Felix Riemann <>
Date:   Tue Sep 8 11:47:13 2009 +0200

    Compare collate keys case-sensitively when sorting the image list
    
    Fixes broken image order in some locales (eg. cs_CZ). Fixes bgo#594403.

Btw, thanks for screencasting. :-)
Comment 3 Kamil Páral 2009-09-08 10:37:34 UTC
All the filenames were lowercase...?

I will confirm the fix, in which build will the fix be available? Thanks.
Comment 4 Felix Riemann 2009-09-08 11:11:13 UTC
(In reply to comment #3)
> All the filenames were lowercase...?
No, with GLib one can convert a filename into a collate key which allows ordering using a simple strcmp (which is case-sensitive). But we ignored the case before this.

> I will confirm the fix, in which build will the fix be available? Thanks.

Fix is in 2.27.92.
Comment 5 Kamil Páral 2009-09-16 09:09:08 UTC
It looks fixed, thank you.

Note You need to log in before you can comment on or make changes to this bug.