After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 590268 - PAM_BAD_ITEM is Linux-PAM only
PAM_BAD_ITEM is Linux-PAM only
Status: VERIFIED FIXED
Product: gnome-keyring
Classification: Core
Component: general
git master
Other opensolaris
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2009-07-30 13:49 UTC by David Adam
Modified: 2009-07-31 17:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Committed patch to fix the problem. (1.25 KB, patch)
2009-07-31 03:31 UTC, Stef Walter 		committed Details | Review

Description David Adam 2009-07-30 13:49:21 UTC 
The current HEAD revision of gnome-keyring fails to build on OpenSolaris because it references a constant defined only by Linux PAM, PAM_BAD_ITEM.

Build log available at http://build.gnome.org/builders/gnome-keyring-opensol-gcc/builds/16/steps/gnome-keyring%20build/logs/stdio based on git revision b51aaae5133686190ca8aced6b44f14274feeff0

It may be appropriate to redefine this consonant on operating systems which do not support it such as FreeBSD and OpenSolaris. Some useful manpages for standard PAM return values include http://docs.sun.com/app/docs/doc/819-2247/pam-3pam?a=view#Return%20Values and http://www.freebsd.org/cgi/man.cgi?query=pam#RETURN_VALUES

Full uname: SunOS manduba 5.11 snv_101 sun4u sparc SUNW,Ultra-Enterprise
Comment 1 Stef Walter 2009-07-31 03:31:13 UTC 
Created attachment 139604 [details] [review]
Committed patch to fix the problem.

I think this should fix the problem. Vincent, since this is your code, can you give it a look and see if it's correct?

commit 9c505e89975af6d8849987e4d1ecb88d1e8482f9
Author: Stef Walter <stef@memberwebs.com>
Date:   Fri Jul 31 03:25:32 2009 +0000

    [pam] Fix use of constant not found in Solaris or FreeBSD.
    
    The PAM_BAD_ITEM constant is linux specific. We don't need to use it,
    so I've removed usage. Fixes bug #590268
Comment 2 Vincent Untz 2009-07-31 15:18:21 UTC 
Oh, didn't know it was linux-specific, sorry about this!
(fix is right, thanks Stef!)