After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 586409 - port cdda backend to libgudev
port cdda backend to libgudev
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: cdda backend
git master
Other Linux
: Normal normal
: ---
Assigned To: Martin Pitt
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2009-06-19 17:05 UTC by Martin Pitt
Modified: 2009-07-08 17:27 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28

Attachments
patch (6.67 KB, patch)
2009-06-20 13:23 UTC, Martin Pitt 		committed Details | Review

Description Martin Pitt 2009-06-19 17:05:25 UTC 
With hal being deprecated, it would be nice to be able to build gvfs without hal. cdda is one of the modules which need to be ported over to gudev.

(FYI, see https://wiki.ubuntu.com/Halsectomy for current status)
Comment 1 Martin Pitt 2009-06-19 17:05:51 UTC 
I'm going to give this a try, I want to learn gudev anyway.
Comment 2 Martin Pitt 2009-06-20 13:23:37 UTC 
Created attachment 137066 [details] [review]
patch

Here it is. That was a nice little exercise to learn gudev. I tested it with an audio CD in my USB CD drive, and ensured that gvfsd-cdda auto-unmounts on both "tray open" (change event to "no media") and "rip out USB cable" (remove event on sr0). "gvfs-info -f cdda://sr0/" shows the correct size with gudev. Backend builds and works with just gudev, just libhal, both (then gudev is used), and does not build if neither is available.
Comment 3 Martin Pitt 2009-06-20 14:06:49 UTC 
Oops, I just noticed that in the very last hunk I forgot a 

  g_object_unref (gudev_device);
Comment 4 Matthias Clasen 2009-06-22 15:11:16 UTC 
Patch looks fine to me (with the correction you pointed out)
Comment 5 David Zeuthen (not reading bugmail) 2009-07-07 13:36:51 UTC 
Will review this (and other hal->gudev patches) soon, haven't forgot, will get to it this week.
Comment 6 David Zeuthen (not reading bugmail) 2009-07-08 17:27:33 UTC 
Pushed the patch with that fix. Thanks.