After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 585757 - Remove deprecated GTK+ symbols from unused code
Remove deprecated GTK+ symbols from unused code
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 0.10.16
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 585692
 
 
Reported: 2009-06-14 18:02 UTC by André Klapper
Modified: 2009-06-14 18:32 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description André Klapper 2009-06-14 18:02:25 UTC
According to http://www.gnome.org/~fpeters/299.html gst-plugins-good contains
deprecated GTK+ symbols that must be removed for GNOME3.

See http://library.gnome.org/devel/gtk/stable/ for the API reference and how to
substitute.

See http://live.gnome.org/GnomeGoals/RemoveDeprecatedSymbols/GTK%2B for a general
explanation.

List of deprecated symbols:
"gtk_label_set, gtk_object_set, gtk_socket_steal, gtk_widget_set_usize"
Comment 1 Tim-Philipp Müller 2009-06-14 18:15:48 UTC
This is all in old code that merely exists in the git repository but isn't actually ever compiled ...


gst-plugins-good$ git grep -e gtk_label_set -e gtk_object_set -e gtk_socket_steal -e gtk_widget_set_usize
ext/dv/demo-play.c:  gtk_widget_set_usize (gtk_socket, 720, 576);
ext/dv/demo-play.c:  gtk_socket_steal (GTK_SOCKET (gtk_socket), draw);
ext/dv/demo-play.c:  gtk_object_set (GTK_OBJECT (appwindow), "allow_grow", TRUE, NULL);
ext/dv/demo-play.c:  gtk_object_set (GTK_OBJECT (appwindow), "allow_shrink", TRUE, NULL);
tests/old/examples/level/demo.c:  gtk_label_set (GTK_LABEL (elapsed), label);

Comment 2 Sebastian Dröge (slomo) 2009-06-14 18:19:48 UTC
Maybe we should remove all that unused, old code :) For everybody who needs it, it is still in the GIT history
Comment 3 Tim-Philipp Müller 2009-06-14 18:32:28 UTC
That was my plan as well:

commit 7ade32216f530790e77e0634cb5d1c60ed265f59
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Sun Jun 14 19:19:19 2009 +0100

    Remove a few old example apps from the 0.8 days
    
    Some have been replaced by newer ones, others are demoing elements that
    don't exist any longer (not in -good anyway), and others have not been
    touched in many years and it seem pointless to keep them around.
    
    Removing these files makes sure we don't have any code in our repository
    that uses Gtk+ symbols which are to be removed for GNOME3, and as such
    will make some script that greps for this kind of stuff give us a clean
    bill of code health. Fixes #585757.