Bug 584223 - HIGify connection editor
HIGify connection editor
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nm-applet
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Dan Williams
Dan Williams
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2009-05-29 17:31 UTC by Christian Persch
Modified: 2009-06-03 19:42 UTC (History)
0 users

See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch series (138.90 KB, patch)
2009-05-29 17:33 UTC, Christian Persch 		none Details | Diff | Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Christian Persch 2009-05-29 17:31:49 UTC 
The connection editor needs HIG improvements:

- borders, spacings, packing properties are wrong
- many strings have wrong capitalisation
- many labels are missing mnemonics
- many labels don't have the correct mnemonic target set

Attached patch series corrects all of these problems I could find.
Comment 1 Christian Persch 2009-05-29 17:33:59 UTC 
Created attachment 135569 [details] [review]
patch series

(Depends on the patches from bug 583918 being applied first.)
Comment 2 Dan Williams 2009-06-03 19:42:13 UTC 
all committed with the exception of "[PATCH 04/32] Make nm-connection-editor window a GtkDialog" which I'd like to drop for the moment; the "All users" checkbox was placed there to ensure the dialog didn't get too tall, since it's there for every connection.  I think before we move that we should figure out how to make the editor dialog less tall, which we need to do anyway for netbooks and such.  It needs an interaction engineer to go over it.  Thanks again!
Note You need to log in before you can comment on or make changes to this bug.