After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 582755 - Addition of golden spiral to rectangle tool guides
Addition of golden spiral to rectangle tool guides
Status: RESOLVED OBSOLETE
Product: GIMP
Classification: Other
Component: User Interface
2.6.6
Other All
: Normal enhancement
: ---
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2009-05-15 11:42 UTC by Boris Abramovich
Modified: 2018-05-24 12:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch for the enhancement (16.71 KB, patch)
2009-05-15 11:43 UTC, Boris Abramovich
needs-work Details | Review
updated patch (6.92 KB, patch)
2009-05-16 08:12 UTC, Boris Abramovich
none Details | Review
git generated patch (6.93 KB, patch)
2009-05-16 14:34 UTC, Boris Abramovich
reviewed Details | Review
cleaned up version of this patch (7.66 KB, patch)
2009-05-16 17:11 UTC, Sven Neumann
needs-work Details | Review

Description Boris Abramovich 2009-05-15 11:42:08 UTC
I have made a patch that add a golden spiral (fibonacci spiral) to the rectagle tools guides. I mainly use it for cropping photographs.
There is some explanation of the use of this guide can be found in the following links.

http://www.powerretouche.com/Divine_proportion_tutorial.htm#tutorial
http://cwlawrencephoto.blogspot.com/2006/04/golden-section-in-photo-composition.html
http://www.fabiovisentin.com/blog/45.ashx

I am submitting a patch relative to the 2.6.6.


I hope it to be of interest to other gimp users.
I will be happy to add alterations if needed.

Boris
Comment 1 Boris Abramovich 2009-05-15 11:43:12 UTC
Created attachment 134699 [details] [review]
patch for the enhancement
Comment 2 Martin Nordholts 2009-05-15 16:04:59 UTC
Thanks! Let's consider adding this for 2.8.
Comment 3 Sven Neumann 2009-05-15 17:02:22 UTC
This patch implements several features at the same time. It would be nice if you could provide a patch that only adds the golden spiral. The other changes can be discussed separately.
Comment 4 Boris Abramovich 2009-05-15 17:11:24 UTC
(In reply to comment #3)
> This patch implements several features at the same time. It would be nice if
> you could provide a patch that only adds the golden spiral. The other changes
> can be discussed separately.
> 

I didn't inted to add more then one feature...
I added the spiral with the posibility to flip and rotate the spiral.  There are 8 possible spiral positions.

There is no point to add the spiral in one direction only....

Thanks,
Boris
Comment 5 Sven Neumann 2009-05-15 20:24:55 UTC
Well, the tool options are already cluttered so much. We are certainly not going to add more controls only to be able to flip and rotate a guide. You will have to come up with a solution that needs less screen estate.

Also the patch has coding style issues and it won't apply against the current development tree as we already included another type of guides (see bug #566443).
Comment 6 Boris Abramovich 2009-05-16 03:41:08 UTC
(In reply to comment #5)
> Well, the tool options are already cluttered so much. We are certainly not
> going to add more controls only to be able to flip and rotate a guide. You will
> have to come up with a solution that needs less screen estate.
> 
> Also the patch has coding style issues and it won't apply against the current
> development tree as we already included another type of guides (see bug
> #566443).
> 

O.K. I will try to  come up with an other proposal that will also cleanly patch against the current developement. I was not aware of coding style issues. I'll try to discover them and correct them.

Do you think that the aproach of adding to the gides combo two possibilities - vertical golden spirals and horizontal golden spirals, each of them drawing four symmetrical spiral guides on the screen would be acceptable?


Thanks,
Boris
Comment 7 Boris Abramovich 2009-05-16 08:12:19 UTC
Created attachment 134749 [details] [review]
updated patch

This is an improved solution in the lines of my previous post.
It works against rev. 28270 of the trunk hopefully has no coding style issues and uses no extra controls.

I am prepared to improve it farther if this is not yet acceptable.


Boris
Comment 8 Martin Nordholts 2009-05-16 08:14:37 UTC
I'd just like to point out that we are using git now:
http://git.gnome.org/cgit/gimp/
Comment 9 Boris Abramovich 2009-05-16 14:34:03 UTC
Created attachment 134758 [details] [review]
git generated patch
Comment 10 Boris Abramovich 2009-05-16 14:37:26 UTC
(In reply to comment #8)
> I'd just like to point out that we are using git now:
> http://git.gnome.org/cgit/gimp/
> 

Thanks Martin,
I had no Idea. The patch applies cleanly to the git trunk. But I attached a patch generated by git anyway.

Boris
Comment 11 Sven Neumann 2009-05-16 17:11:02 UTC
Created attachment 134766 [details] [review]
cleaned up version of this patch
Comment 12 Sven Neumann 2009-05-16 17:11:52 UTC
I find the four spirals drawn at the same time rather confusing. Also the combo box becomes very wide due to the length of the added items. Perhaps we can get a good idea from the UI department how this could be solved better?

In the meantime I have attached a cleaned up version of your patch. I tried to improve the readability a little and removed the whitespace errors your patch introduced.
Comment 13 Boris Abramovich 2009-05-16 18:19:07 UTC
(In reply to comment #12)
> I find the four spirals drawn at the same time rather confusing. Also the combo
> box becomes very wide due to the length of the added items. Perhaps we can get
> a good idea from the UI department how this could be solved better?
> 
> In the meantime I have attached a cleaned up version of your patch. I tried to
> improve the readability a little and removed the whitespace errors your patch
> introduced.
> 

Thanks.

I see that the constraints in developing a program like the GIMP are more numerous then I suspected ;-).
I agree that the 4 spirals are somewhat confusing at first.

The only other idea I have is to add the flip check boxes conditionaly so that they will take presious screen estate only when you select the specific guides in the combo, but I am not sure whether this is acceptable.

In any case I'll be happy to implement any suggestion that you'll come up with.

And about the white space errors is there any automatic tool that flags these and other coding style issues?

Boris
Comment 14 Sven Neumann 2009-05-17 09:25:15 UTC
You can certainly configure your editor to show trailing white-space.
Comment 15 Martin Nordholts 2009-08-08 11:44:41 UTC
The patches themselves look fine to me.
Comment 16 Martin Nordholts 2010-06-23 15:17:13 UTC
Interesting from original author has faded away, moving off milestones.
Comment 17 Boris Abramovich 2010-06-23 19:44:40 UTC
(In reply to comment #16)
> Interesting from original author has faded away, moving off milestones.

I am still very interested I Just don't see a way acceptable by Sven to incorporate this fiture in the current gui.

My sujestions  were not accepted and there were no other sujestions. So I see no way to proceed.
Comment 18 Sven Neumann 2010-06-29 18:58:43 UTC
Well, what this patch is waiting for for more than year now is for someone to take the discussion to the gimp-developer mailing-list and ask for advice from the UI designers.
Comment 19 Boris Abramovich 2010-06-30 03:46:37 UTC
(In reply to comment #18)
> Well, what this patch is waiting for for more than year now is for someone to
> take the discussion to the gimp-developer mailing-list and ask for advice from
> the UI designers.

Now I understand.  I hade no idea that by  "the UI department" you ment the UI designers at gimp-developer. Well, Sven you all developed a wonderfull software that I enjoy using very much. But it seems to me that the team could use some more patience for the first time would-be contributors doing their first steps in trying to help.
Comment 20 Michael Schumacher 2016-06-25 21:09:35 UTC
Comment on attachment 134766 [details] [review]
cleaned up version of this patch

per comment 12
Comment 21 GNOME Infrastructure Team 2018-05-24 12:34:06 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gimp/issues/303.