After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 580320 - Migrate deprecated gnome-vfs to gio/gvfs
Migrate deprecated gnome-vfs to gio/gvfs
Product: libgsf
Classification: Core
Component: GNOME
Other Linux
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks: 588321 588322
Reported: 2009-04-26 18:37 UTC by André Klapper
Modified: 2009-07-11 16:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Description André Klapper 2009-04-26 18:37:40 UTC
According to libgsf 1.14.11 still uses gnome-vfs.

$:andre\> grep -r libgnomevfs .
./gsf-gnome/gsf-input-gnomevfs.h:#include <libgnomevfs/gnome-vfs.h>
./gsf-gnome/gsf-input-gnomevfs.c:#include <libgnomevfs/gnome-vfs-method.h>
./gsf-gnome/gsf-output-gnomevfs.h:#include <libgnomevfs/gnome-vfs.h>

gnome-vfs usage has been completely removed from GNOME for 2.27, but this is the very last module pulling it in as libgsf is a blessed dependency.
Comment 1 Morten Welinder 2009-04-27 00:25:24 UTC
According to me, libgsf does not use gnome-vfs.  At least not unless you
insist on compiling it in.

The three #include statements above are conditional.  If you have gio,
the gsf/gnomevfs api will be emulated.
Comment 2 Morten Welinder 2009-04-27 01:30:58 UTC
It might be a good idea to configure --without-bonobo if you really want
a legacy-free libgsf.  Otherwise, it'll use it if available.
Comment 3 André Klapper 2009-04-30 14:30:58 UTC
Thanks for clarifying (I can't check every single line for #ifdef's, sorry) and also covering bonobo.
I really appreciate it.
Going to whitelist libgsf for now.
Comment 4 Daniel Macks 2009-05-12 03:37:38 UTC
git trunk still has gsf-gnome/gsf-{in,out}put-gnomevfs.h:

> * The installed version will always do this.  For our emulation layer, we
> * want to avoid it.
> */
>#include <libgnomevfs/gnome-vfs.h>

Even if gnome-vfs isn't compiled-in and libgsf-gnome doesn't use gnome-vfs, when another package tries to use libgsf-gnome, doesn't that drag in gnome-vfs headers (by design, per the comment)?
Comment 5 Morten Welinder 2009-05-12 04:06:41 UTC
Certainly.  But to do that, the calling application is already using
gnome-vfs, so we are not adding any dependency there.