After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 575710 - Dialog messages include unfriendly dbus freedesktop.org strings
Dialog messages include unfriendly dbus freedesktop.org strings
Status: RESOLVED FIXED
Product: gnome-disk-utility
Classification: Core
Component: general
unspecified
Other All
: Normal minor
: ---
Assigned To: gnome-disk-utility-maint
Depends on:
Blocks:
 
 
Reported: 2009-03-17 15:36 UTC by jlaska
Modified: 2009-03-28 17:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-don-t-show-dbus-error-names.patch (861 bytes, patch)
2009-03-27 03:17 UTC, Matthias Clasen
committed Details | Review
0002-add-a-missing-else.patch (1.02 KB, patch)
2009-03-27 03:17 UTC, Matthias Clasen
committed Details | Review
0003-sync-GduError-to-DevkitDisksError.patch (4.07 KB, patch)
2009-03-27 03:18 UTC, Matthias Clasen
committed Details | Review
0004-improve-the-error-dialog.patch (7.96 KB, patch)
2009-03-27 03:18 UTC, Matthias Clasen
committed Details | Review

Description jlaska 2009-03-17 15:36:26 UTC
The dialogs could be made more user-friendly by translating the dbus reponse message better.  For example, when trying to format XFS (without xfsprogs installed) it fails as one would expect.

The message though reveals a bit too much about the internals: 

"org.freedesktop.DeviceKit.Disks.Error.Failed: Error creating file system: helper exited with exit code 1: cannot spawn 'mkfs.xfs -L 
          "Fedora Live" /dev/sdb1': Failed to execute child process "mkfs.xfs" (No such file or directory)"

Other information:
Comment 1 Matthias Clasen 2009-03-27 03:17:17 UTC
Created attachment 131479 [details] [review]
0001-don-t-show-dbus-error-names.patch
Comment 2 Matthias Clasen 2009-03-27 03:17:46 UTC
Created attachment 131480 [details] [review]
0002-add-a-missing-else.patch
Comment 3 Matthias Clasen 2009-03-27 03:18:07 UTC
Created attachment 131481 [details] [review]
0003-sync-GduError-to-DevkitDisksError.patch
Comment 4 Matthias Clasen 2009-03-27 03:18:26 UTC
Created attachment 131482 [details] [review]
0004-improve-the-error-dialog.patch
Comment 5 Matthias Clasen 2009-03-27 03:19:57 UTC
Here is a series of patches that remove the dbus error name from the UI,
sync the GduError enum with the DK-d errors, and improves the error dialog by showing a translated string corresponding to error->code and moving error->message to a detail expander.

The sync patch has already been attached to another bug.
Comment 6 David Zeuthen (not reading bugmail) 2009-03-28 17:19:41 UTC
Applied. Btw, please pay attention to compiler warnings

gdu-error.c: In function â_gdu_error_fixupâ:
gdu-error.c:58: warning: unused variable âsâ