Bug 574626 - No obvious way to display FT manager
No obvious way to display FT manager
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: File Transfer
2.25.x
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2009-03-09 12:35 UTC by Guillaume Desmottes
Modified: 2009-04-27 14:40 UTC (History)
2 users (show)

See Also:
GNOME target: ---
GNOME version: 2.25/2.26


Attachments
add "Show File Transfers" to the Chat menu (2.49 KB, patch)
2009-04-27 02:05 UTC, Danielle Madeley
reviewed Details | Diff | Review

Description Guillaume Desmottes 2009-03-09 12:35:41 UTC
There is no obvious way to display the file transfer manager window if you closed it.
Comment 1 Xavier Claessens 2009-03-09 13:28:16 UTC
Right, main window should have a menu entry for that, should be trivial to add.
Comment 2 Danielle Madeley 2009-04-27 02:05:15 UTC
Created attachment 133384 [details] [review]
add "Show File Transfers" to the Chat menu

http://git.collabora.co.uk/?p=user/davyd/empathy-davyd.git;a=shortlog;h=refs/heads/fix-574626
Comment 3 Xavier Claessens 2009-04-27 08:18:21 UTC
instead of gtk_wiget_show() why not gtk_window_presence()? To be sure you get the dialog on the current desktop and with focus.

Also, you could add an icon on the menu entry, we use "document-send" icon name.
Comment 4 Danielle Madeley 2009-04-27 09:53:44 UTC
Updated and merged.
Comment 5 Guillaume Desmottes 2009-04-27 11:08:14 UTC
Actually I'm not convinced that the chat menu is the right place for this. Maybe it's time to add a "View" menu.
Comment 6 Xavier Claessens 2009-04-27 11:58:17 UTC
We should rework the whole menu. There is another bug about that afaik.
Comment 7 Danielle Madeley 2009-04-27 14:40:14 UTC
I umm'ed and err'ed about this. And couldn't come up with a convincing decision either way. It's easy enough to change.

Note You need to log in before you can comment on or make changes to this bug.