After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 572134 - Get rid of deprecated gnome-vfs
Get rid of deprecated gnome-vfs
Status: RESOLVED FIXED
Product: dasher
Classification: Applications
Component: general
4.9.x
Other Linux
: Normal normal
: ---
Assigned To: Patrick Welche
dasher-maint
Depends on:
Blocks: 588322
 
 
Reported: 2009-02-17 11:49 UTC by André Klapper
Modified: 2009-07-11 16:02 UTC
See Also:
GNOME target: 2.26.x
GNOME version: ---

Attachments
Remove remaining gnome-vfs calls (1.54 KB, patch)
2009-02-17 16:38 UTC, palfrey 		none Details | Review

Description André Klapper 2009-02-17 11:49:10 UTC 
See http://live.gnome.org/GioPort

$:andre\> grep -r gnomevfs .
./Src/main.cc:#include <libgnomevfs/gnome-vfs.h>

$:andre\> grep -r gnome_vfs .
./Src/Gtk2/dasher_editor_internal.cpp:  // error_dialog = gtk_message_dialog_new(GTK_WINDOW(window), GTK_DIALOG_MODAL, GTK_MESSAGE_ERROR, GTK_BUTTONS_OK, "Could not open the file \"%s\"\n%s\n", myfilename, gnome_vfs_result_to_string(*result));
./Src/main.cc:  gnome_vfs_init();
./Src/main.cc:  gnome_vfs_shutdown();
Comment 1 palfrey 2009-02-17 16:38:45 UTC 
Created attachment 128907 [details] [review]
Remove remaining gnome-vfs calls

The remaining calls were only init/teardown + one commented function, so an easy fix.

Default build on my system still links in gnome-vfs to the dasher binary, but recompiling with "-Wl,--as-needed" drops that, as it's still getting pulled in from other libraries for the moment (need to upgrade a few things).
Comment 2 André Klapper 2009-02-17 17:15:53 UTC 
Site note: http://svn.gnome.org/viewvc/dasher?view=revision&revision=3605 should have had fixed most gnome-vfs stuff, just for historical reference.
Comment 3 Patrick Welche 2009-03-02 11:32:28 UTC 
Commited - thank you
Comment 4 André Klapper 2009-03-02 22:55:42 UTC 
Great, thanks a lot!
For reference: http://svn.gnome.org/viewvc/dasher?view=revision&revision=3632
Comment 5 Patrick Welche 2009-03-06 21:57:30 UTC 
I couldn't believe my eyes when I saw an ubuntu update to firefox this morning to add support for gnome-vfs!