After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 570785 - Suggested trivial enhancement to the gsf tool
Suggested trivial enhancement to the gsf tool
Status: RESOLVED OBSOLETE
Product: libgsf
Classification: Core
Component: General
unspecified
Other All
: Normal enhancement
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2009-02-06 13:29 UTC by Tor Lillqvist
Modified: 2018-05-22 12:54 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Tor Lillqvist 2009-02-06 13:29:32 UTC
As the binary MS Office formats contain substreams with nonprintable characters in their names it would be nice to be able to pass such names to gsf dump or gsf cat as backslash-escaped octal instead of having to remember how to quote binary chars in the shell... Also improved the usage message a bit. Trivial patch below, ok to commit?

Index: tools/gsf.c
===================================================================
--- tools/gsf.c (revision 1041)
+++ tools/gsf.c (working copy)
@@ -74,6 +74,7 @@
 static GsfInput *
 find_member (GsfInfile *arch, char const *name)
 {
+       name = g_strcompress (name);
        char const *slash = strchr (name, '/');

        if (slash) {
@@ -382,6 +383,7 @@

        if (argc <= 1) {
                g_printerr (_("Usage: %s %s\n"), me, usage);
+               g_printerr (_("Run: %s help for a list of subcommands\n"), me);
                return 1;
        }
Comment 1 Morten Welinder 2009-02-08 00:49:47 UTC
> ok to commit?

It leaks, but once you fix that I am ok with it.
Comment 2 GNOME Infrastructure Team 2018-05-22 12:54:27 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/libgsf/issues/4.