Bug 570285 – Use of g_return_if_fail to catch data errors

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 570285 - Use of g_return_if_fail to catch data errors


Summary:	Use of g_return_if_fail to catch data errors


Status:	RESOLVED OBSOLETE

Product:	libgsf
Classification:	Core
Component:	General
Version:	unspecified
Hardware:	Other All

Importance:	Normal minor
Target Milestone:	---
Assigned To:	Jody Goldberg
QA Contact:	Jody Goldberg

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2009-02-02 21:52 UTC by sum1
Modified:	2018-05-22 12:54 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Trace from https://launchpad.net/bugs/325902 (2.06 KB, text/plain) 2009-02-06 00:32 UTC, Connor Imes	Details

Description sum1 2009-02-02 21:52:23 UTC

Version: r1040
OS: Ubuntu Intrepid

Steps to reproduce:
- Download Attachment 104243 [details] (.xls file from Bug 513831)
- ssconvert attachment.xls /tmp/foo.txt


Console output:

libgsf:msole-CRITICAL **: ole_dirent_new: assertion `!seen_before[entry]' failed
libgsf:msole-CRITICAL **: ole_dirent_new: assertion `!seen_before[entry]' failed
libgsf:msole-CRITICAL **: ole_dirent_new: assertion `!seen_before[entry]' failed


Backtrace:

(gdb) bt

+ Trace 212145

#0 IA__g_return_if_fail_warning
at /build/buildd/glib2.0-2.18.2/glib/gmessages.c line 525
#1 ole_dirent_new
at gsf-infile-msole.c line 299
#2 ole_dirent_new
at gsf-infile-msole.c line 377
#3 ole_dirent_new
at gsf-infile-msole.c line 381
#4 ole_init_info
at gsf-infile-msole.c line 610
#5 gsf_infile_msole_new
at gsf-infile-msole.c line 935
#6 excel_file_probe
at boot.c line 107
#7 go_plugin_loader_module_func_file_probe
at go-plugin-loader-module.c line 224
#8 go_plugin_file_opener_probe
at go-plugin-service.c line 445
#9 go_file_opener_probe
at file.c line 274
#10 wb_view_new_from_input
at workbook-view.c line 1194
#11 wb_view_new_from_uri
at workbook-view.c line 1284
#12 convert
at ssconvert.c line 291
#13 main
at ssconvert.c line 401

Comment 1 Morten Welinder 2009-02-04 20:47:07 UTC

Well, that was how bug 513831 got fixed.  I guess we could make our own
g_return_... macros, but I am not sure that leaves us better off.

Comment 2 Connor Imes 2009-02-06 00:31:19 UTC

This stacktrace here was matched by the dup finder from the stacktrace filed today on Launchpad at https://launchpad.net/bugs/325902

I'll attach the trace, can you decide if the root cause is the same?

Comment 3 Connor Imes 2009-02-06 00:32:27 UTC

Created attachment 128064 [details]
Trace from https://launchpad.net/bugs/325902

Comment 4 Morten Welinder 2009-02-19 02:09:56 UTC

Retitling to reflect that the problem is the use of g_return_if_fail or
its _val_ variant.

Comment 5 Morten Welinder 2009-02-19 02:11:52 UTC

Re https://launchpad.net/bugs/325902

Insufficient data to determine whether the bugs are the same.  This bug
will only create a crash if glib is asked to abort on criticals.

A sample file would be useful.

Comment 6 GNOME Infrastructure Team 2018-05-22 12:54:18 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/libgsf/issues/3.