Bug 566335 - No obvious way to leave fullscreen
No obvious way to leave fullscreen
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
2.24.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2009-01-02 16:11 UTC by Wouter Bolsterlee (uws)
Modified: 2009-03-30 18:13 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: ---


Attachments
Adds a "Full Screen" option in the popup menu (403 bytes, patch)
2009-03-11 23:09 UTC, Simon van der Linden
rejected Details | Diff | Review
Adds a "Leave Full Screen" item in the popup menu (2.04 KB, patch)
2009-03-12 22:36 UTC, Simon van der Linden
committed Details | Diff | Review

Description Wouter Bolsterlee (uws) 2009-01-02 16:11:58 UTC
When g-t is running in fullscreen mode without a menu bar, there is no obvious way to leave the fullscreen mode. While I don't suggest having a "leave fullscreen" button in the corner of the screen (as many other gnome apps do), a context menu item would be helpful.
Comment 1 Simon van der Linden 2009-03-11 23:09:15 UTC
Created attachment 130493 [details] [review]
Adds a "Full Screen" option in the popup menu
Comment 2 Christian Persch 2009-03-12 17:20:18 UTC
I think comment 0 has a better suggestion; there should be an "Exit fs" item that's ONLY shown when IN fullscreen mode.
Comment 3 Simon van der Linden 2009-03-12 22:36:23 UTC
Created attachment 130559 [details] [review]
Adds a "Leave Full Screen" item in the popup menu 

(In reply to comment #2)
> I think comment 0 has a better suggestion; there should be an "Exit fs" item
> that's ONLY shown when IN fullscreen mode.

I didn't understand it that way; indeed, that's another solution.

After all, I prefer the first solution. I'm not fan of (dis)appearing items in menus and the check button has the advantage that we can enter the full screen mode from the popup menu as well.
Comment 4 Christian Persch 2009-03-12 22:41:01 UTC
Thanks! Please commit to trunk after we branch for 2-26 next week.
Comment 5 Wouter Bolsterlee (uws) 2009-03-12 23:01:12 UTC
Thanks for working on this, Simon. Do you have a SVN account or should someone else commit it? Please let me know if you want me to do it for you.

(Nogmaals bedankt! :))
Comment 6 Simon van der Linden 2009-03-12 23:23:10 UTC
(In reply to comment #5)
> Thanks for working on this, Simon. Do you have a SVN account or should someone
> else commit it? Please let me know if you want me to do it for you.

Please do it for me; I don't have an SVN account.

> (Nogmaals bedankt! :))

Geen dank ;)
Comment 7 Christian Persch 2009-03-30 17:21:32 UTC
Committed to trunk; thanks for the patch!
Comment 8 Wouter Bolsterlee (uws) 2009-03-30 18:13:49 UTC
Oops, thanks for committing, Christian.

Note You need to log in before you can comment on or make changes to this bug.