After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 563250 - Save and restore custom composer accelerators
Save and restore custom composer accelerators
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.24.x (obsolete)
Other Linux
: Normal enhancement
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
evolution[composer]
Depends on:
Blocks:
 
 
Reported: 2008-12-04 17:10 UTC by Matthew Barnes
Modified: 2008-12-10 11:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (1.90 KB, patch)
2008-12-05 06:31 UTC, Matthew Barnes
committed Details | Review

Description Matthew Barnes 2008-12-04 17:10:15 UTC
Still learning new things about GTK...

Now that the composer is using GtkUIManager for menus, it's now possible to edit menu accelerators on the fly (if the GNOME setting is enabled).  That much I knew.  What I didn't know is the application is reponsible for loading and saving those custom accelerators, otherwise the customizations won't survive beyond the current Evolution session.

The solution to this is gtk_accel_map_load() and gtk_accel_map_save().

Note: This will be applicable to the rest of Evolution once Bonobo is gone.
Comment 1 Matthew Barnes 2008-12-04 17:12:41 UTC
Other applications save their accelerator maps to ~/.gnome2/accels.  I assume that's still the standard location for now.  Eventually I expect them to move under ~/.config.
Comment 2 Matthew Barnes 2008-12-05 06:31:52 UTC
Created attachment 123977 [details] [review]
Proposed patch

This should also cover the CompEditor subclasses.
Of course the _real_ fun begins on the kill-bonobo branch...
Comment 3 Srinivasa Ragavan 2008-12-10 08:25:51 UTC
Awesome. Go to trunk/stable. [I dont feel this is a str/ui break]
Comment 4 Matthew Barnes 2008-12-10 11:55:59 UTC
Agreed.  Committed to trunk (rev 36864) and gnome-2-24 (rev 36865).