Bug 562033 - Risky -I ordering can cause build failure
Risky -I ordering can cause build failure
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
2.24.x
Other Mac OS
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2008-11-23 17:56 UTC by Daniel Macks
Modified: 2008-11-23 20:30 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
Local -I before global (860 bytes, patch)
2008-11-23 17:57 UTC, Daniel Macks 		committed Details | Diff | Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Daniel Macks 2008-11-23 17:56:19 UTC 
metacity-2.24.0/src/Makefile.am passes -I flags for external support libs before those for the source tree. If any .h installed in the standard places on my system happens to have the same name as one that comes with metacity, compiling can fail because the compiler will find the wrong header. Should always pass all local -I before the globals.
Comment 1 Daniel Macks 2008-11-23 17:57:29 UTC 
Created attachment 123275 [details] [review]
Local -I before global

Also removed a space between the -I flag itself and its pathname argument. Apparently some compilers can't handle that (or libtool gets confused or something).
Comment 2 Thomas Thurman 2008-11-23 20:30:22 UTC 
Thanks.  Committed in r4029.
Note You need to log in before you can comment on or make changes to this bug.