After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 561770 - Allow .gih image pipe brushes to provide a custom thumbnail (patch incl.)
Allow .gih image pipe brushes to provide a custom thumbnail (patch incl.)
Status: RESOLVED OBSOLETE
Product: GIMP
Classification: Other
Component: General
unspecified
Other All
: Normal enhancement
: ---
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2008-11-21 06:32 UTC by Tommy
Modified: 2018-05-24 12:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to allow brush offset to main array in .gih files (5.77 KB, patch)
2008-11-21 06:34 UTC, Tommy
needs-work Details | Review

Description Tommy 2008-11-21 06:32:32 UTC
I've started designing GIMP brushes and am impressed with the flexibility available. However I've come across the problem that the only way to choose the brush thumbnail (the icon that appears in the brush chooser) and the brush outline at the cursor is to use one of the actual brush frames.

With some animated brushes the end result doesn't look much like any of the individual frames.

A simple example is a brush I just made which spatters dots around randomly when you draw with it. It uses a large centered spot as the brush thumbnail which is not a very good preview of what the brush does.

http://mesilliac.deviantart.com/art/Spatter-animated-GIMP-brush-104173139


I thought that a good way to allow making a custom brush thumbnail would be to allow the .gih file to specify an offset for the brushes inside it, so that the first x brushes will be ignored when drawing, but the initial brush in the file is still used as the thumbnail.

It was pretty straightforward so I made a patch that allows this.

It doesn't affect the current brushes at all, they just use the default offset of 0.


The patch is against GIMP version 2.6.1 as provided by Ubuntu, but I can make one against svn if needed.
Comment 1 Tommy 2008-11-21 06:34:28 UTC
Created attachment 123149 [details] [review]
patch to allow brush offset to main array in .gih files
Comment 2 Sven Neumann 2008-11-21 19:00:41 UTC
This is likely to break backward compatibility of the format. It would be nicer to find a solution that also works with older versions of GIMP. Perhaps you want to discuss this on the gimp-developer mailing-list...
Comment 3 GNOME Infrastructure Team 2018-05-24 12:27:51 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gimp/issues/286.