Bug 561114 – Escape should close/cancel focused toplevel dialog

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 561114 - Escape should close/cancel focused toplevel dialog


Summary:	Escape should close/cancel focused toplevel dialog


Status:	RESOLVED FIXED

Product:	gnome-power-manager
Classification:	Deprecated
Component:	general
Version:	SVN TRUNK
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	GNOME Power Manager Maintainer(s)
QA Contact:	GNOME Power Manager Maintainer(s)

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2008-11-16 21:55 UTC by Rui Matos
Modified:	2008-11-17 13:48 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
activate cancel/close button on escape (3.85 KB, patch) 2008-11-16 21:56 UTC, Rui Matos	none	Details \| Review

Description Rui Matos 2008-11-16 21:55:05 UTC

Hi,

gnome-power-manager's GUIs don't usually bind the Escape key to close dialogs.
Maybe it is intentional, maybe not, but please consider applying the patch I'm
attaching to do that.

As an added bit of polish I've made the patch in a way that the close/cancel
button in question will give visual feedback that its action is being
activated.

I'm actually thinking of adding this patch to all GNOME modules and to GTK+
itself so any comments on this first version are very welcome.

Comment 1 Rui Matos 2008-11-16 21:56:31 UTC

Created attachment 122821 [details] [review]
activate cancel/close button on escape

Comment 2 Richard Hughes 2008-11-17 13:48:01 UTC

2008-11-17  Richard Hughes  <richard@hughsie.com>

	* data/gpm-inhibit-test.glade:
	* data/gpm-prefs.glade:
	* data/gpm-statistics-old.glade:
	* data/gpm-statistics.glade:
	* src/gpm-prefs-core.c: (gpm_prefs_activate_window),
	(gpm_prefs_init):
	* src/gpm-statistics-core.c: (gpm_statistics_activate_window),
	(gpm_statistics_init):
	* src/gpm-statistics.c: (gpm_gnome_activated_cb), (main):
	Change the dialog windows to be a GtkDialog, not a GtkWindow.
	Fixes #561114