Bug 560311 - Update devhelp plugin to use webkit version
Update devhelp plugin to use webkit version
Status: RESOLVED FIXED
Product: anjuta
Classification: Applications
Component: plugins: devhelp
SVN TRUNK
Other Linux
: Normal normal
: ---
Assigned To: Naba Kumar
Anjuta maintainers
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2008-11-11 10:50 UTC by Ignacio Casal Quinteiro (nacho)
Modified: 2008-11-30 12:33 UTC (History)
3 users (show)

See Also:
GNOME target: ---
GNOME version: ---


Attachments
devhelp (14.85 KB, patch)
2008-11-11 10:52 UTC, Ignacio Casal Quinteiro (nacho)
none Details | Diff | Review
devhelp v2 (15.26 KB, patch)
2008-11-14 14:21 UTC, Ignacio Casal Quinteiro (nacho)
needs-work Details | Diff | Review
devhelp v3 (19.33 KB, patch)
2008-11-18 21:47 UTC, Ignacio Casal Quinteiro (nacho)
none Details | Diff | Review
devhelp v4 (19.65 KB, patch)
2008-11-29 19:26 UTC, Ignacio Casal Quinteiro (nacho)
none Details | Diff | Review
devhelp v5 (22.87 KB, patch)
2008-11-29 22:17 UTC, Ignacio Casal Quinteiro (nacho)
committed Details | Diff | Review

Description Ignacio Casal Quinteiro (nacho) 2008-11-11 10:50:55 UTC
I am going to attach a patch in the next message.
Comment 1 Ignacio Casal Quinteiro (nacho) 2008-11-11 10:52:49 UTC
Created attachment 122399 [details] [review]
devhelp

Theorically this should work without the history, but here I am getting an error that it cannot be found the symbol: dh_assistant_view_get_type. So I cannot test it. If anybody knows why this is happening...
Comment 2 Ignacio Casal Quinteiro (nacho) 2008-11-14 14:21:52 UTC
Created attachment 122660 [details] [review]
devhelp v2

This is the same as the previous one but with configure.in edited.
Comment 3 Sébastien Granjoux 2008-11-16 11:21:22 UTC
Normally, this function dh_assistant_view_get_type is defined in devhelp in src/dh-assistant-view.c in the line:

G_DEFINE_TYPE (DhAssistantView, dh_assistant_view, WEBKIT_TYPE_WEB_VIEW);

I have recompiled Anjuta and I don't get an error. It's probably an error on your environment. Recompile and reinstall devhelp. Then in anjuta directory rerun ./autogen, then make and make install. If it doesn't work, you can try make distclean in anjuta directory before trying again.
Comment 4 Johannes Schmid 2008-11-17 22:55:03 UTC
Just add

$(PLUGIN_DEVHELP_LIBS) to the Makefile.am and it will work (of course you have to rebuild):

# Plugin dependencies
libanjuta_devhelp_la_LIBADD = \
	$(GTK_LIBS) \
	$(LIBANJUTA_LIBS) \
	$(PLUGIN_DEVHELP_LIBS)


Plugin is not working very well though.
Comment 5 Ignacio Casal Quinteiro (nacho) 2008-11-18 21:47:21 UTC
Created attachment 122987 [details] [review]
devhelp v3

The plugin right now supports the same things than in the previous one.
Known issues:
 * The back/forward buttons aren't updated very well.
 * The search tab is getting too much size.

Could you check this things?
Comment 6 Ignacio Casal Quinteiro (nacho) 2008-11-29 19:26:40 UTC
Created attachment 123658 [details] [review]
devhelp v4

Same than before but fixing the size requested by the search tab.
Comment 7 Ignacio Casal Quinteiro (nacho) 2008-11-29 22:17:09 UTC
Created attachment 123670 [details] [review]
devhelp v5

Now the back/forward are working and placed in the left panel.
Next step will be the eggfindbar.
Comment 8 Johannes Schmid 2008-11-30 10:29:33 UTC
Thanks!
Comment 9 Frederic Peters 2008-11-30 12:33:31 UTC
Note WebKit has not yet been approved for 2.26, I didn't check what was commited but the patch would make a regression in anjuta (no devhelp plugin) if devhelp/webkit is not part of 2.26.

Note You need to log in before you can comment on or make changes to this bug.