After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 550721 - UI improvement when adding a new layout
UI improvement when adding a new layout
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Keyboard
2.23.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-09-03 19:07 UTC by Vincent Untz
Modified: 2009-02-14 13:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
a patch (1010 bytes, patch)
2009-02-14 04:24 UTC, Matthias Clasen
none Details | Review

Description Vincent Untz 2008-09-03 19:07:23 UTC
When I open the add layout dialog, I'm presented with a nice window which is... not friendly because nothing is selected by default.

It'd be nice to select a country by default (it'll be easier to select a language by default, I guess, but that would imply moving the language tab as first tab)
Comment 1 Sergey V. Udaltsov 2008-09-03 20:08:37 UTC
I dont mind moving language tab into the first position. Is there any standard universal way to figure out the language from the locale? Just taking first two letters of the $LANG envvar?
Comment 2 Vincent Untz 2008-09-03 21:20:06 UTC
AFAIK, the format is:

[language[_territory][.codeset][@modifier]].

You should use g_get_language_names() to get a list of locales that apply.

(note that this change breaks the UI freeze, though, so you should either wait for 2.25 or ask release-team and gnome-doc-list for approval)
Comment 3 Matthias Clasen 2009-02-14 02:59:14 UTC
Can we still get this done for 2.26 ?

People are filing bugs about the initial unselected state:

https://bugzilla.redhat.com/show_bug.cgi?id=484518
Comment 4 Matthias Clasen 2009-02-14 04:24:24 UTC
Created attachment 128706 [details] [review]
a patch

Here is a patch that selects the first layout initially.
Better than no selection at all.
Comment 5 Sergey V. Udaltsov 2009-02-14 13:56:46 UTC
Thanks, I am happy with that patch. I guess it does not break any freezes - it is just a fix.