GNOME Bugzilla – Bug 537679
Notification Icon Opens to Wrong Size in Vertical Area
Last modified: 2008-06-17 21:42:35 UTC
With a vertical notification area every time you start Banshee the notification icon gets set to its largest size, taking up too much relative space in the area. Moving the area's panel to a horizontal position and back resets the size until the next time Banshee is run.
This is due to some oversights in the use of the Tomboy icon sizing code. I'll attach a patch.
Created attachment 112510 [details] [review] Get the ParentWindow for the EventBox, not the Plug, when checking orientation. In the original Tomboy code "this" was the EventBox, whereas in the Banshee code "this" is the Plug containing the EventBox, so ParentWindow was always coming back null and the orientation wasn't actually being checked. I noticed that with this patch the overly-large size is allocated in the notification area before the icon appears, and then after a second or so the proper-sized icon appears correctly in the notification area as you would expect. I'll look into it.
(In reply to comment #2) > I noticed that with this patch the overly-large size is allocated in the > notification area before the icon appears, and then after a second or so the > proper-sized icon appears correctly in the notification area as you would > expect. I'll look into it. Actually, I guess it always had that problem...or at least it seems to have that problem even without my patch applied. Never noticed it before. Anyway, since it's not a regression I'm less concerned about fixing it.
*** Bug 537886 has been marked as a duplicate of this bug. ***
Fixed in r4159.